Angus/add profile fixes - #33
Merged
Merged
Conversation
rosbag2 on ROS 2 Iron+/Jazzy serializes offered_qos_profiles policies as string names (e.g. 'keep_last', 'reliable', 'transient_local', 'automatic') instead of the legacy integer values. The IntEnum-typed Qos fields rejected those strings with a pydantic ValidationError, breaking `kappe convert` on recordings from newer ROS distros. Add a BeforeValidator that maps the string name onto the enum (case-insensitive) while passing ints/enums through unchanged, so both the new string form and the legacy integer form parse. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Danahirmt
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same changes as #31 but to master