py: require python 3.10+ and make misc dependency updates#211
py: require python 3.10+ and make misc dependency updates#211consideRatio merged 5 commits intosensmetry:mainfrom
Conversation
Signed-off-by: Erik Sundell <erik.sundell+2025@sensmetry.com>
Signed-off-by: Erik Sundell <erik.sundell+2025@sensmetry.com>
Signed-off-by: Erik Sundell <erik.sundell+2025@sensmetry.com>
consideRatio
force-pushed
the
pr/bump-python-stuff
branch
2 times, most recently
from
dc7855a to
d7cf247
Compare
andrius-puksta-sensmetry
left a comment
andrius-puksta-sensmetry
left a comment
There was a problem hiding this comment.
LGTM, just remove unnecessary requirements as noted above.
| - name: Publish to PyPI | ||
| if: ${{ github.event_name == 'push' && startsWith(github.ref, 'refs/tags/') }} | ||
| run: | | ||
| curl -LsSf https://astral.sh/uv/install.sh | sh |
There was a problem hiding this comment.
Fine by me, but I wanted to be as simple as possible here, since this is really sensitive. Also, astral-sh/setup-uv does a lot of stuff that's not needed here at all, like setting up caching and so on.
There was a problem hiding this comment.
I think we should use the action to avoid getting issues stemming from a difference between tested/published tooling. Since you included fine by me, I didn't revert this change.
Security wise I reason that if the action used in a job (any step of the job) with access to more credentials, we are in trouble, so using it in the final publish step won't matter I think.
|
No idea what's wrong with CI, changes don't seem to touch these parts... |
Signed-off-by: Erik Sundell <erik.sundell+2025@sensmetry.com>
consideRatio
force-pushed
the
pr/bump-python-stuff
branch
from
d7cf247 to
ed3c720
Compare
Signed-off-by: Erik Sundell <erik.sundell+2025@sensmetry.com>
2 participants
Uh oh!
There was an error while loading. Please reload this page.