Closed
Conversation
• The regression was in the lock path, not in add itself. The latest commit made lock generation require project.sources(), and
embedded InMemoryProject instances for stdlib dependencies still hard-panicked there. I fixed that in memory.rs and populated
concrete RemoteKpar sources for embedded stdlib projects in stdlib.rs.
Verification:
- cargo test -p sysand-core stdlib_projects_have_nominal_sources
- Exact repro, with network enabled for the index lookup:
d=$(mktemp -d) && cd "$d" && cargo run --manifest-path /home/erik/dev/sensmetry/sysand/Cargo.toml init && cargo run --manifest-
path /home/erik/dev/sensmetry/sysand/Cargo.toml add urn:kpar:sysmod
That flow now succeeds, creates sysand-lock.toml, and installs urn:kpar:sysmod 5.0.0-alpha.2 instead of panicking.
Signed-off-by: Erik Sundell <erik.sundell+2025@sensmetry.com>
• Updated the failing follow-up test to match the new InMemoryProject::sources() behavior. I changed project_derive.rs so test_macro_sources now asserts vec![] instead of expecting a panic. That was the concrete failure caused by the previous fix. on-behalf-of: @sensmetry <erik.sundell+2025@sensmetry.com> Signed-off-by: Erik Sundell <erik.sundell+2025@sensmetry.com>
Comment on lines
+137
to
138
| "https://www.omg.org/spec/SysML/20250201/Quantities-and-Units-Domain-Library.kpar", | ||
| "https://www.omg.org/spec/SysML/20250201/Quantities-and-Units-Domain-Library.kpar", |
Collaborator
There was a problem hiding this comment.
Duplicates
andrius-puksta-sensmetry
requested changes
Mar 12, 2026
Collaborator
andrius-puksta-sensmetry
left a comment
andrius-puksta-sensmetry
left a comment
There was a problem hiding this comment.
Ok, except duplicates have to be cleaned up.
Collaborator
|
After thinking a bit, in my opinion it would be better to not even try including sources for But |
Collaborator
Author
|
@victor-linroth-sensmetry @andrius-puksta-sensmetry this is out my comfort zone to pick up - in order to ensure we don't let this fall between the chairs, who works it? |
Collaborator
Author
|
Just for reference, closing to clarify I'm not actively working it. |
Collaborator
|
Fix included in #154, since it already touched |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observed regression in main branch, mentioned in #206, is potentially fixed by these changes, generated by codex GPT 5.4. The text below is AI generated, and the changes are as well. I haven't looked into this myself. I have only verified that this change does unbreak
sysand add urn:kpar:sysmodspecifically.The regression was in the lock path, not in add itself. The latest commit made lock generation require project.sources(), and embedded InMemoryProject instances for stdlib dependencies still hard-panicked there. I fixed that in memory.rs and populated concrete RemoteKpar sources for embedded stdlib projects in stdlib.rs.
Verification:
That flow now succeeds, creates sysand-lock.toml, and installs urn:kpar:sysmod 5.0.0-alpha.2 instead of panicking.