Fix request headers and use rustls for all targets#183
Merged
andrius-puksta-sensmetry merged 9 commits intomainfrom Mar 13, 2026
Merged
Fix request headers and use rustls for all targets#183andrius-puksta-sensmetry merged 9 commits intomainfrom
andrius-puksta-sensmetry merged 9 commits intomainfrom
Conversation
72406fe to
dcf536f
Compare
205a9fa to
fc5bb9e
Compare
5866e2a to
f39187a
Compare
consideRatio
approved these changes
Mar 13, 2026
Collaborator
consideRatio
left a comment
There was a problem hiding this comment.
I think this is sound, manual testing has failed for index due to the unrelated issue being fixed in another PR, but I have tried a few other things and considered how things could fail to provide the headers without seeing red-flags.
Let's go!
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com> bump MSRV to latest Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com> revert Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
Signed-off-by: Andrius Pukšta <andrius.puksta@sensmetry.com>
f39187a to
62a19f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include appropriate headers for all requests:
User-Agent: sysand/<version>Accept: appropriate values for each type of request (kpar, json, text)macOS native TLS (as used by Rust's
security-framework) does not support TLS 1.3. Windows 10secure-channelalso does not support TLS 1.3 (Windows 11 does, but bindings don't expose it).So use
rustlsfor all targets. Certificate verification is done natively by each platform, so OS trust stores and rules are used.Tests to do:
__token__, pass is PAT):__token__, pass is PAT):