Skip to content

Fix curl error handling and revert maintainer to project address#7

Merged
senet merged 1 commit into
feat/easy-installfrom
copilot/sub-pr-4-again
Feb 8, 2026
Merged

Fix curl error handling and revert maintainer to project address#7
senet merged 1 commit into
feat/easy-installfrom
copilot/sub-pr-4-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 8, 2026

Summary

  • Purpose and scope - Addresses code review feedback on PR Feat/easy install #4
  • Linked issue
  • Testing done - Shellcheck passed, curl error handling verified

Changes

Error handling:

  • Added -f flag to curl in libexec/kctl-env-list-remote so HTTP errors (403 rate limit, 404, 5xx) trigger the error handler instead of silently failing with empty output

Maintainer metadata:

  • Reverted personal email to project address (kctl-env Maintainers <kctl-env@example.com>) in:
    • packaging/debian/control Maintainer field
    • scripts/release.sh Debian changelog entry
    • scripts/release.sh RPM changelog entry

Checklist

  • Branch based on latest main
  • No direct commits to main
  • Updated README.md / docs if needed
  • Updated CHANGELOG.md for user-facing changes
  • Added/updated tests (if applicable)
  • For releases: used make release V=X.Y.Z and opened PR from release/vX.Y.Z

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI mentioned this pull request Feb 8, 2026
9 tasks
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Feb 8, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/kubernetes/kubernetes/tags
    • Triggering command: /usr/bin/curl curl -sSLf REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Add bootstrap installer for easy installation Fix curl error handling and revert maintainer to project address Feb 8, 2026
Copilot AI requested a review from senet February 8, 2026 11:15
@senet senet marked this pull request as ready for review February 8, 2026 11:17
@senet senet merged commit bd62efa into feat/easy-install Feb 8, 2026
1 check passed
@senet senet deleted the copilot/sub-pr-4-again branch February 8, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants