Skip to content

Add macOS compatibility for SHA256 verification in installer#14

Merged
senet merged 2 commits into
feat/easy-installfrom
copilot/sub-pr-4-again
Feb 8, 2026
Merged

Add macOS compatibility for SHA256 verification in installer#14
senet merged 2 commits into
feat/easy-installfrom
copilot/sub-pr-4-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 8, 2026

Summary

  • Purpose and scope
  • Linked issue
  • Testing done

Addresses feedback on PR #4: installer hard-required sha256sum, unavailable on macOS by default.

Changes

  • Added compute_sha256() helper: Auto-detects available hash tool in priority order: sha256sum (Linux) → shasum -a 256 (macOS) → openssl dgst -sha256 (fallback)
  • Removed sha256sum from required commands: No longer blocks macOS users
  • Updated checksum verification: Calls helper instead of direct sha256sum
compute_sha256() {
  local file="$1"
  if command -v sha256sum >/dev/null 2>&1; then
    sha256sum "$file" | awk '{print $1}'
  elif command -v shasum >/dev/null 2>&1; then
    shasum -a 256 "$file" | awk '{print $1}'
  elif command -v openssl >/dev/null 2>&1; then
    openssl dgst -sha256 "$file" | awk '{print $NF}'
  else
    echo "Error: No SHA256 tool found (tried: sha256sum, shasum, openssl)" >&2
    exit 1
  fi
}

Checklist

  • Branch based on latest main
  • No direct commits to main
  • Updated README.md / docs if needed
  • Updated CHANGELOG.md for user-facing changes
  • Added/updated tests (if applicable)
  • For releases: used make release V=X.Y.Z and opened PR from release/vX.Y.Z

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI mentioned this pull request Feb 8, 2026
9 tasks
Co-authored-by: senet <4061835+senet@users.noreply.github.com>
Copilot AI changed the title [WIP] Update easy install feature based on review feedback Add macOS compatibility for SHA256 verification in installer Feb 8, 2026
Copilot AI requested a review from senet February 8, 2026 12:16
@senet senet marked this pull request as ready for review February 8, 2026 12:23
@senet senet merged commit 78d4ca7 into feat/easy-install Feb 8, 2026
@senet senet deleted the copilot/sub-pr-4-again branch February 8, 2026 12:23
senet added a commit that referenced this pull request Feb 8, 2026
* Initial plan

* Add macOS compatibility for SHA256 verification with fallback support

Co-authored-by: senet <4061835+senet@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: senet <4061835+senet@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants