docs(sms): document E.164 recipient requirement for SMS sends - #96
Merged
Conversation
The hosted API now rejects a non-E.164 SMS `to` with 400 invalid_recipient (template and raw sends alike) instead of accepting it and failing at dispatch. Reflect that contract in the SDK surface: - senderkit_send_raw `to` now spells out the per-channel recipient formats, including the E.164 requirement for sms, matching senderkit_send. This also improves the `senderkit send-raw` CLI help derived from the manifest. - README SMS example notes the E.164 requirement and the 400 response. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MyKX5gt1HHZoV2YW4729qs
The `pnpm audit --audit-level=moderate` CI gate started failing on two freshly-published advisories affecting transitive deps pulled in via @modelcontextprotocol/sdk (used by @senderkit/cli): - high — fast-uri < 3.1.5 (host confusion via backslash authority): our override floor was pinned at >=3.1.4, one patch below the fix. - moderate — hono < 4.12.34 (ReDoS in CORS middleware): floor was >=4.12.27. Both existing overrides simply sat below the patched versions, so the audit gate broke on main and every open PR regardless of content. Bump the floors to the patched versions; lockfile now resolves fast-uri 3.1.5 and hono 4.13.0. `pnpm audit --audit-level=moderate` is clean, frozen install / build / tests / typecheck all pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E5ZYJUHAmibPyaKyKmQLSQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The hosted API now enforces that an SMS recipient (
to) must be an E.164 phone number. A non-E.164 SMStois rejected up front with400 invalid_recipient— for both template sends and raw sends — instead of being accepted and failing later at dispatch.This aligns the SDK/CLI/MCP surface with that contract. No behavior change in the client itself (recipient validation stays server-side); these are description/doc corrections so callers format numbers correctly and understand the failure mode.
MCP manifest (
@senderkit/sdk)senderkit_send_raw'stofield description now spells out the per-channel recipient formats — including the E.164 requirement forsms— matchingsenderkit_send, which already documented it. Previouslysend_raw'stoonly mentioned the web-push subscription shape, leaving the SMS format undocumented on the exact tool where the channel is stated explicitly.CLI (
@senderkit/cli)senderkit send-rawhelp text derives from the manifest, so it now surfaces the same per-channeltoguidance, including E.164 for SMS.Docs
400 invalid_recipientresponse.A patch changeset is included for
@senderkit/sdkand@senderkit/cli.Checklist
pnpm --filter @senderkit/sdk testpasses (86 tests)pnpm --filter @senderkit/cli testpasses (87 tests)pnpm buildsucceeds🤖 Generated with Claude Code
Generated by Claude Code