Skip to content

test(inbound): resolve CodeQL "assert has a side-effect" alerts #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tuyakhov merged 1 commit into from
Jul 29, 2026
Merged

test(inbound): resolve CodeQL "assert has a side-effect" alerts #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions tests/test_inbound.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ def test_delete_inbound_address(client):
respx.delete(f"{BASE_URL}/v1/inbound/addresses/inb_1").mock(
return_value=httpx.Response(200, json={"deleted": True})
)
assert client.inbound.addresses.delete("inb_1") is True
deleted = client.inbound.addresses.delete("inb_1")
assert deleted is True


@respx.mock
Expand Down Expand Up @@ -265,7 +266,8 @@ def test_delete_inbound_domain(client):
respx.delete(f"{BASE_URL}/v1/inbound/domains/d3").mock(
return_value=httpx.Response(200, json={"deleted": True})
)
assert client.inbound.domains.delete("d3") is True
deleted = client.inbound.domains.delete("d3")
assert deleted is True


@respx.mock
Expand Down Expand Up @@ -360,7 +362,8 @@ async def test_delete_inbound_domain_async(aclient):
respx.delete(f"{BASE_URL}/v1/inbound/domains/d3").mock(
return_value=httpx.Response(200, json={"deleted": True})
)
assert await aclient.inbound.domains.delete("d3") is True
deleted = await aclient.inbound.domains.delete("d3")
assert deleted is True


@respx.mock
Expand Down Expand Up @@ -405,7 +408,8 @@ async def test_async_inbound_addresses_full_surface(aclient):
respx.delete(f"{BASE_URL}/v1/inbound/addresses/inb_9").mock(
return_value=httpx.Response(200, json={"deleted": True})
)
assert await aclient.inbound.addresses.delete("inb_9") is True
deleted = await aclient.inbound.addresses.delete("inb_9")
assert deleted is True


@respx.mock
Expand Down