Support for textSuffix and forceEvaluate flags - #64
Open
vigneshk-fd wants to merge 5 commits into
Open
vigneshk-fd wants to merge 5 commits into
vigneshk-fd wants to merge 5 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the wonderful add-on.
I would like to add two new flags to the add-on for enhanced usability.
Example scenario : A simple table that list products, where the line clamp component is used in the name column. The name columns needs to display the product id, along with the name text. Also the name column is resizable, so that ellipsis has to be recomputed based on the new width.
textSuffix--> Suffix text that can be appended after the ellipsis (before See More/See Less link)Example :
textSuffix: "#ID-001"Rendered as : "helloWorld helloWorld ... #ID-001 See More"
forceEvaluate--> Boolean flag that the parent components can pass to re-evaluate the clamping logic.Example :
forceEvaluate: false (parent container width: 300px)Rendered as : "helloWorld helloWorld ... See More"
forceEvaluate: true (parent container width: 100px)Rendered as : "helloWorld ... See More"
Added test cases for each flag as well.