fix(bench): Update DOOP zxing dataset URL to HuggingFace mirror#506
Merged
fix(bench): Update DOOP zxing dataset URL to HuggingFace mirror#506
Conversation
The original host (pages.cs.wisc.edu/~m0riarty) returns 404 and is no longer maintained. Point at the FlowLog VLDB 2026 artifact mirror on HuggingFace (NemoYuu/flowlog_benchmark), which the upstream project now uses for dataset distribution. Also harden the script: - Honour DOOP_ZXING_URL to override the source without editing the file - Use curl --fail so HTTP errors abort the script - Validate the archive with unzip -tq before extraction, so a future broken mirror surfaces a clear error instead of a misleading "cannot find zipfile directory" failure - Move tmpdir/zip cleanup into a trap so partial downloads are removed even when the script exits early
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pages.cs.wisc.edu/~m0riarty) now returns404and is no longer maintained, sobench/data/doop/download.shcannot fetch the dataset.NemoYuu/flowlog_benchmark), which the upstream project now uses for distribution.cannot find zipfile directoryfailures.Script hardening
DOOP_ZXING_URLto override the source without editing the file.curl --failso HTTP errors abort the script.unzip -tqbefore extraction; if the server returned HTML (e.g. a 404 page), surface a clear error.trapso partial downloads are removed even on early exit.Verification
bash bench/data/doop/download.shfrom a clean state: 34 CSV files (~83 MB) extracted successfully.bash scripts/run_doop_validation.sh --workers 1 --repeat 1returnedOK(6,276,653 output tuples, 28 iterations, 136.3 s wall, ~16.4 GB peak RSS).Test plan
DOOP_ZXING_URL=<bad-url> bash bench/data/doop/download.shfails fast with the new error message rather than anunzipdiagnostic.scripts/run_doop_validation.shstill reportsPASSagainst the newly downloaded dataset.