feat(#460): Binary-size regression gate#499
Merged
Conversation
Add scripts/ci/check-text-size.sh that extracts the .text section size from the built library, compares against the committed baseline in tests/baseline_size.txt, and fails if growth exceeds the 5120-byte budget (section 14, #446). Baseline recorded from Linux GCC build (ubuntu:24.04, 148496 bytes).
Add .text size regression gate to ci-pr.yml (blocking, Linux GCC only) and ci-main.yml (non-blocking monitoring). Runs after build+test, before sanitizers, to avoid wasting compute on size-rejected builds.
justinjoy
force-pushed
the
feat/460-binary-size-gate
branch
from
a7d4565 to
e7cfbe5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/ci/check-text-size.shthat extracts.textsection size fromlibwirelog.so, compares against committed baseline, and fails if growth exceeds 5120-byte budget (section 14, feat: Option C user-defined I/O adapters (static + Android + optional CLI dlopen) #446)tests/baseline_size.txt, verified via Docker ubuntu:24.04 buildci-pr.yml(Linux GCC only) and non-blocking monitor inci-main.ymlTest plan
Closes #460