Skip to content

feat(hermes): emit pending approval events - #43

Merged
selvalabs merged 1 commit into
mainfrom
hermes-admin-approval-pending-event
Jul 24, 2026
Merged

feat(hermes): emit pending approval events#43
selvalabs merged 1 commit into
mainfrom
hermes-admin-approval-pending-event

Conversation

@selvalabs

Copy link
Copy Markdown
Owner

Summary

  • Emits a Hermes admin_approval_pending event when a new resident registration is created with notifications_approved=false.
  • Adds admin_approval_pending to the Hermes event catalog.
  • Covers the registration flow with API-level test coverage.

Scope

  • Audit/event only: no Telegram, WhatsApp, webhook, deploy, credentials, or LLM calls.

Validation

  • uv run pytest tests/unit/test_users_api.py::test_create_user_emits_pending_approval_hermes_event -q
  • uv run pytest tests/unit/test_users_api.py tests/unit/test_hermes_catalog.py -q
  • uv run ruff check .
  • uv run mypy src
  • uv run pytest

Closes #42
Refs #37

@selvalabs
selvalabs marked this pull request as ready for review July 24, 2026 23:52
@selvalabs
selvalabs merged commit 575463f into main Jul 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(hermes): emit event for pending admin approval

2 participants