feat(notifications): require admin approval - #34
Merged
Conversation
Co-authored-by: Selva Labs <selvalabs@users.noreply.github.com>
8 tasks
feat(notifications): bootstrap Hermes event audit
feat(admin): expose Hermes event audit endpoints
feat(hermes): process events locally
feat(hermes): emit monitoring failure events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notifications_approved=falseas the default for new registrations.Validation
DATABASE_URL=sqlite:////tmp/monitor-approval-test2.db uv run ruff check .DATABASE_URL=sqlite:////tmp/monitor-approval-test2.db uv run mypy srcDATABASE_URL=sqlite:////tmp/monitor-approval-test2.db uv run pytest -qDATABASE_URL=sqlite:////tmp/monitor-approval-migration.db uv run monitor-comunitario db-upgradeDATABASE_URL=sqlite:////tmp/monitor-approval-migration.db uv run monitor-comunitario db-currentOperational note
This keeps the Venusiana WhatsApp pilot safer: registrations are collected, but no notification is released until an admin approves the number.