chore(test): consolidate execution outcome metrics coverage - #38
Merged
Merged
Conversation
Replace separate completed and lease-loss metric tests with one bounded outcome matrix covering every ExecutionOutcome variant. Verify that each completed execution increments the total execution count, does not increment the unhandled count, and increments exactly one matching outcome counter. The rest of Steda's embedded unit tests already protect distinct contracts, so leave them intentionally granular.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tightens Steda’s execution metrics unit coverage without changing production code.
Two separate outcome tests are replaced with one table-driven test covering every
ExecutionOutcomevariant:CompletedFailedLeaseLostCancelledSuspendedFor each outcome, the test verifies that the total execution count increments, the unhandled count remains unchanged, and exactly one matching bounded outcome counter is recorded.
The rest of Steda’s embedded unit suite remains intentionally unchanged because those tests already protect distinct durability, parsing, serialization, retry-classification, and database-boundary contracts.