chore(test): consolidate low-signal unit coverage - #89
Merged
Merged
Conversation
Reduce unit-test fragmentation without weakening the behavioral coverage that protects Kival's important contracts. Consolidate malformed metrics parser cases, Prometheus sanitization cases, histogram state transitions, label conversion shapes, BlobRef parsing and canonicalization, commentary mention parsing, and nested metadata rejection into stronger scenario or table-driven tests. Remove assertions that duplicate stronger coverage or constrain incidental implementation details, including histogram in-place sorting, redundant process metric collection, tracing default fields, and BlobRef debug formatting. This keeps the security, storage, parsing, API, WebAuthn, concurrency, and durability-oriented tests intact while making the unit suite smaller and easier to reason about.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduces Kival’s embedded unit-test surface from 148 tests to 118 without changing production code or dropping meaningful behavioral coverage.
The cleanup consolidates fragmented fixture-by-fixture tests around metrics parsing, Prometheus sanitization, histogram behavior, label conversion,
BlobRefparsing, commentary mention parsing, and nested metadata validation.It also removes tests that only duplicated stronger coverage or constrained incidental implementation details, including histogram in-place sorting, redundant process-metrics coverage, tracing default-field assertions, and
BlobRefdebug formatting.Security, storage, API, WebAuthn, concurrency, parsing, and durability-oriented tests remain intact.