You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds Screen.set_keyboard_flags() event handler, to handle progressive enhancement events.
The Screen class therefore maintains a stack of Screen.keybord_flags, which is managed by set_keybord_flags() handler, if Stream detects related CSI = flags ; mode u, CSI > flags u or CSI < count u escape sequences.
Sending proper key sequences to shell is up to a real terminal implementation, which can use Screen.keyboard_flags to query requested features.
This PR ensures not to pass through related escape sequences to buffer.
Well, I've rarely seen general *args and *kwargs being typed anywhere as they can contain arbritary number of arguments of any type. In this special case list[int] might work as this is what arguments of CSI sequences are defined as.
An unfortunate issue with mypy is that it does not type check functions if any type hint is missing (at least not by default). I guess you could use object or Any?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #194
This PR adds
Screen.set_keyboard_flags()event handler, to handle progressive enhancement events.The
Screenclass therefore maintains a stack ofScreen.keybord_flags, which is managed byset_keybord_flags()handler, ifStreamdetects relatedCSI = flags ; mode u,CSI > flags uorCSI < count uescape sequences.Sending proper key sequences to shell is up to a real terminal implementation, which can use
Screen.keyboard_flagsto query requested features.This PR ensures not to pass through related escape sequences to buffer.