Add keypad mode escape sequences DECKPAM and DECKPNM#193
Open
deathaxe wants to merge 6 commits intoselectel:masterfrom
Open
Add keypad mode escape sequences DECKPAM and DECKPNM#193deathaxe wants to merge 6 commits intoselectel:masterfrom
DECKPAM and DECKPNM#193deathaxe wants to merge 6 commits intoselectel:masterfrom
Conversation
deathaxe
force-pushed
the
feat/keypad-modes
branch
from
170e767 to
3b886e0
Compare
This commit adds support for `DECKPAM` and `DECKPNM` escape sequences, to set keypad mode. If such escape sequence is found `Stream` emits `Screen.set_keypad_mode()`, which sets `Screen.keypad_mode` flag to one of `KeypadMode` enum values. An enumeration is used to provide more expressive values for type checking as a boolean would be able to express. Related specification: - https://vt100.net/docs/vt510-rm/DECKPAM.html - https://vt100.net/docs/vt510-rm/DECKPNM.html
deathaxe
force-pushed
the
feat/keypad-modes
branch
from
3b886e0 to
fc70a87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #141
Superseeds #142
This PR adds support for
DECKPAMandDECKPNMescape sequences, to set keypad mode.If such escape sequence is found
StreamemitsScreen.set_keypad_mode(), which setsScreen.keypad_modeflag to one ofKeypadModeenum values.An enumeration is used to provide more expressive values for type checking
as a boolean would be able to express.
For applications to correctly check for active keypad mode,
KeypadModeclass is exported.Keypad mode is said to be non-persistent and thus reset to numeric mode by
reset()event.Related specification: