dev: Ensure latest setuptools used in CI#229
Open
adigitoleo wants to merge 6 commits into
Open
Conversation
Member
Author
|
Well, the MacOS CI failure persists. The error message is confusing, as the logs show that setuptools v82 is being used, which is newer than the suggested v70.1, more investigation required. |
Member
Author
|
No luck on newer macos runner either. I don't think we want it to build llvmlite anyway should ideally just download a pre-built one? Might need to pin llmvlite version |
Member
|
Sorry, I cannot manage to make it work either... |
Member
Author
|
No worries I'll consider either pinning llvmlite (in pyproject.toml, kinda ugly as it then affects other platforms) or play around with adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like the Python setup action in CI doesn't respect☹️ This ensures that the latest setuptools is being used in CI. I made the matching change to the virtual environment setup script.
[build-system]inpyproject.tomlMaybe this will resolve the failures to install llmvlite in the MacOS runner.