Skip to content

fix(giga): finalize state on failed transactions for V2 compatibility #2829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pdrobnjak wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(giga): finalize state on failed transactions for V2 compatibility #2829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions app/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@
upgradekeeper "github.com/cosmos/cosmos-sdk/x/upgrade/keeper"
upgradetypes "github.com/cosmos/cosmos-sdk/x/upgrade/types"
"github.com/ethereum/go-ethereum/core"
"github.com/ethereum/go-ethereum/core/tracing"
ethtypes "github.com/ethereum/go-ethereum/core/types"
"github.com/ethereum/go-ethereum/core/vm"
"github.com/ethereum/go-ethereum/ethclient"
Expand Down Expand Up @@ -1867,8 +1868,18 @@
gigaExecutor := gigaexecutor.NewGethExecutor(*blockCtx, stateDB, cfg, vm.Config{}, gigaprecompiles.AllCustomPrecompilesFailFast)

// Execute the transaction through giga VM
// Note: Execute() internally calls BuyGas() which deducts fees from sender's balance
execResult, execErr := gigaExecutor.ExecuteTransaction(ethTx, sender, app.GigaEvmKeeper.GetBaseFee(ctx), &gp)
if execErr != nil {
// Execution failed (e.g., intrinsic gas error, floor data gas error)
// BuyGas() was already called inside Execute(), so fees were deducted.
// We need to:
// 1. Increment the nonce (Execute() didn't get far enough to do this)
// 2. Finalize to commit the fee deduction and nonce increment
// This matches V2 behavior where fees and nonce are always updated for
// transactions that pass ante checks, even if execution fails.
stateDB.SetNonce(sender, stateDB.GetNonce(sender)+1, tracing.NonceChangeEoACall)
stateDB.Finalize() // Commit fee deduction and nonce increment

Check failure on line 1882 in app/app.go

View workflow job for this annotation

GitHub Actions / lint 

Error return value of `stateDB.Finalize` is not checked (errcheck)
return &abci.ExecTxResult{
Code: 1,
Log: fmt.Sprintf("giga executor apply message error: %v", execErr),
Expand Down
Loading