Skip to content

Conversation

@codchen
Copy link
Collaborator

@codchen codchen commented Feb 10, 2026

Describe your changes and provide context

When a delegator delegates more tokens to a validator that they've already delegated to, their rewards with that validator will be withdrawn automatically. We want this withdrawal to be accompanied by an event when delegation/redelegation happens through the staking precompile.

Testing performed to validate your change

unit test

@github-actions
Copy link

github-actions bot commented Feb 10, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedFeb 11, 2026, 7:16 AM

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.77%. Comparing base (ff992dd) to head (faaea59).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
precompiles/staking/staking.go 66.66% 3 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2828       +/-   ##
===========================================
+ Coverage   46.23%   56.77%   +10.53%     
===========================================
  Files        2005     2070       +65     
  Lines      163000   168299     +5299     
===========================================
+ Hits        75366    95547    +20181     
+ Misses      81111    64252    -16859     
- Partials     6523     8500     +1977     
Flag Coverage Δ
sei-chain 40.86% <66.66%> (+0.01%) ⬆️
sei-cosmos 48.12% <ø> (-0.01%) ⬇️
sei-db 68.72% <ø> (ø)
sei-tendermint 58.73% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
precompiles/staking/staking.go 77.30% <66.66%> (-0.27%) ⬇️

... and 354 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sei-will sei-will self-requested a review February 10, 2026 11:46
@codchen codchen enabled auto-merge (squash) February 11, 2026 07:30
@codchen codchen merged commit 21e991f into main Feb 11, 2026
43 checks passed
@codchen codchen deleted the tony/staking-events branch February 11, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants