Flatten `sei-tendermint` go mod into `sei-chain` #2817

masih · 2026-02-06T09:17:09Z

Flatten the sei-tendermint go module into sei-chain tin reduce dependency management complexity and error-prone multi layer replace directives.

Part of PLT-6

Flatten the sei-tendermint go module into sei-chain tin reduce dependency management complexity and error-prone multi layer replace directives. Part of PLT-6

github-actions · 2026-02-06T09:18:08Z

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

Build	Format	Lint	Breaking	Updated (UTC)
`✅ passed`	`✅ passed`	`✅ passed`	`✅ passed`	Feb 10, 2026, 11:14 AM

codecov · 2026-02-06T09:19:45Z

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 48.13%. Comparing base (28bc1c0) to head (321d417).

Files with missing lines	Patch %	Lines
sei-cosmos/server/rosetta/client_online.go	0.00%	1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (28bc1c0) and HEAD (321d417). Click for more details.

HEAD has 3 uploads less than BASE

Flag BASE (28bc1c0) HEAD (321d417)

sei-tendermint 1 0

sei-chain 1 0

sei-db 1 0

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2817       +/-   ##
===========================================
- Coverage   56.77%   48.13%    -8.65%     
===========================================
  Files        2070      666     -1404     
  Lines      168274    50121   -118153     
===========================================
- Hits        95542    24126    -71416     
+ Misses      64247    23885    -40362     
+ Partials     8485     2110     -6375

Flag	Coverage Δ
sei-chain	`?`
sei-cosmos	`48.13% <0.00%> (+0.01%)`	⬆️
sei-db	`?`
sei-tendermint	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
sei-cosmos/baseapp/abci.go	`65.50% <ø> (-0.76%)`	⬇️
sei-cosmos/baseapp/baseapp.go	`71.37% <ø> (-3.39%)`	⬇️
sei-cosmos/baseapp/grpcrouter.go	`91.66% <ø> (ø)`
sei-cosmos/baseapp/grpcrouter_helpers.go	`59.09% <ø> (ø)`
sei-cosmos/baseapp/p2p.go	`65.38% <ø> (ø)`
sei-cosmos/baseapp/params.go	`38.02% <ø> (ø)`
sei-cosmos/baseapp/test_helpers.go	`76.92% <ø> (ø)`
sei-cosmos/client/broadcast.go	`62.22% <ø> (ø)`
sei-cosmos/client/cmd.go	`78.90% <ø> (ø)`
sei-cosmos/client/config/cmd.go	`48.83% <ø> (ø)`
... and 77 more

... and 1507 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

* errcheck: 50 * goconst: 1 * goimports: 3 * gosec: 50 * ineffassign: 2 * misspell: 2 * prealloc: 17 * staticcheck: 45 * unconvert: 1

codecov · 2026-02-09T21:15:23Z

Codecov Report

❌ Patch coverage is 43.04636% with 86 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.11%. Comparing base (28bc1c0) to head (7d3a9b4).

Files with missing lines	Patch %	Lines
cmd/seid/cmd/iavl_parser.go	0.00%	31 Missing ⚠️
loadtest/sign.go	0.00%	25 Missing ⚠️
loadtest/loadtest_client.go	0.00%	14 Missing ⚠️
evmrpc/tests/mock_accounts.go	28.57%	5 Missing and 5 partials ⚠️
app/app.go	50.00%	2 Missing ⚠️
evmrpc/tests/utils.go	33.33%	1 Missing and 1 partial ⚠️
oracle/price-feeder/oracle/jail.go	0.00%	1 Missing ⚠️
sei-cosmos/server/rosetta/client_online.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2817      +/-   ##
==========================================
+ Coverage   56.77%   57.11%   +0.33%     
==========================================
  Files        2070     2088      +18     
  Lines      168274   171053    +2779     
==========================================
+ Hits        95542    97694    +2152     
- Misses      64247    64682     +435     
- Partials     8485     8677     +192

Flag	Coverage Δ
sei-chain	`52.55% <43.04%> (+11.69%)`	⬆️
sei-cosmos	`48.13% <0.00%> (+0.01%)`	⬆️
sei-db	`68.72% <ø> (ø)`
sei-tendermint	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
app/abci.go	`66.92% <ø> (ø)`
app/ante/cosmos_checktx.go	`36.14% <ø> (+0.54%)`	⬆️
app/ante/evm_checktx.go	`33.75% <ø> (ø)`
app/apptesting/test_suite.go	`24.44% <ø> (ø)`
app/benchmark.go	`44.82% <ø> (ø)`
app/benchmark/benchmark.go	`60.00% <ø> (ø)`
app/benchmark/generator.go	`46.04% <ø> (ø)`
app/benchmark/logger.go	`92.92% <ø> (ø)`
app/eth_replay.go	`0.00% <ø> (ø)`
app/export.go	`0.00% <ø> (ø)`
... and 141 more

... and 100 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pompon0 · 2026-02-10T05:44:51Z

sei-tendermint/cmd/tendermint/commands/debug/dump.go

-				dumpDebugData(ctx, logger, rpc, dumpArgs)
-			}
+			ticker := time.NewTicker(time.Duration(frequency) * time.Second) //nolint: gosec
+			defer ticker.Stop()


nit: not needed since 1.23

Although it is not strictly needed after 1.23, there are a few reasons to still call stop: communication of intent, defensive programming in case of refactoring that may move the ticker and so on.
But the main functional reason to call it is that it would stop the ticker immediately, instead of leaving it to GC. It makes up a more predictable code behaviour.

pompon0 · 2026-02-10T05:54:22Z

sei-tendermint/crypto/merkle/proof.go

@@ -153,19 +153,19 @@ func ProofFromProto(pb *tmcrypto.Proof) (*Proof, error) {
 // Recursive impl.
 func computeHashFromAunts(index, total int64, leafHash []byte, innerHashes [][]byte) ([]byte, error) {
 	if index >= total || index < 0 || total <= 0 {
-		return nil, fmt.Errorf("Calling computeHashFromAunts() with invalid index (%d) and total (%d)", index, total)
+		return nil, fmt.Errorf("calling computeHashFromAunts() with invalid index (%d) and total (%d)", index, total)


fyi, the lint which checks that the first letter of the error is lowercase is imprecise and super annoying - sometimes the first letter simply has to be uppercase (like when the first word is a name of a public type, or sth). I'd recommend to disable it.

Agreed that ST1005 can be annoying, but I'd push back on disabling it entirely; the consistency alone is worth it. The general practice is to instead capitalise the first letter in logs, because they typically are a list of sentences. See:

https://go.dev/wiki/CodeReviewComments#error-strings

The "(unless beginning with proper nouns or acronyms)" is loose. As a reference, I very rarely come across Go SDK implementation that falls in that exceptional category.

In this specific case, the error should indeed start with lower case.

pompon0 · 2026-02-10T05:59:43Z

sei-tendermint/internal/consensus/msgs.go

@@ -336,7 +336,7 @@ func newValidBlockMessageFromProto(pb *tmcons.NewValidBlock) (*NewValidBlockMess
 func proposalMessageFromProto(pb *tmcons.Proposal) (*ProposalMessage, error) {
 	proposal, err := types.ProposalFromProto(&pb.Proposal)
 	if err != nil {
-		return nil, fmt.Errorf("Proposal: %w", err)


like here: the field is "Proposal", not "proposal". Lowercasing is not helpful.

Sure, we can keep it uppercase and add a lint ignore. But looking at the repo, the error strings are already inconsistent. Rather than adding lint ignores case by case, I'd suggest adopting a consistent "verb noun/Noun: %w" pattern; example

fmt.Errorf("converting Proposal: %w", err)

This reads well when errors chain and eventually logged; e.g. :

Failed to process peer message: converting Proposal: invalid signature length

vs.

Failed to process peer message: Proposal: invalid signature length

...and naturally avoids the capitalization lint issue entirely. It also matches the Go stdlib pattern (e.g. "tls: failed to find certificate...") where error strings compose mid-sentence as described in the Go Code Review Comments.

This repo doesn't have a logging convention yet. Adopting "verb noun/Noun/WhatEver: %w" now means fewer lint ignores going forward and clearer log lines for debugging.

pompon0 · 2026-02-10T06:02:02Z

sei-tendermint/internal/consensus/peer_state.go

@@ -394,7 +395,7 @@ func (ps *PeerState) ApplyNewRoundStepMessage(msg *NewRoundStepMessage) {
 	defer ps.mtx.Unlock()

 	// ignore duplicates or decreases
-	if msg.HRS.Cmp(ps.PRS.HRS) <= 0 {
+	if msg.Cmp(ps.PRS.HRS) <= 0 {


this lint does something weird - we compare HRS embedded fields here. Hiding that fact harms readability.

This is from QF1008 staticcheck linter. Its rationale is rooted in Effective Go, where the entire point of embedding is promotion; to avoid bookkeeping and decouple from internals.

I'm against always using the explicit form, because that defeats the purpose of the language feature. In this case, HRS is a core type with no clashing receiver functions on both embedder and embedded types in this repo.
If HRS is more than an implementation detail, then my recommendation is to not embed it; use a named field instead. That forces callers to always spell out "I want to compare X and Y by their progress in terms of height, round, step". What harms readability most is allowing two ways of doing the same thing when the intent is to always use one. Keeping QF1008 enabled helps enforce that consistency.

Happy to revert this change in any case.

pompon0 · 2026-02-10T06:02:57Z

sei-tendermint/internal/consensus/peer_state.go

@@ -298,7 +298,8 @@ func (ps *PeerState) EnsureVoteBitArrays(height int64, numValidators int) {
 }

 func (ps *PeerState) ensureVoteBitArrays(height int64, numValidators int) {
-	if ps.PRS.Height == height {
+	switch ps.PRS.Height {


@masih wdyt about this if -> switch lint? Do you find it more readable?

This wasn't a linter suggestion; it was a style choice on my part. The switch makes the two height cases immediately visible as the top-level branching structure, with the nil checks as secondary logic within each. With nested if/else, the height comparison and nil checks sit at the same visual level.

Happy to revert if you prefer the original. You'll be staring at this code more than I will.

sei-tendermint/internal/mempool/tx.go

sei-tendermint/internal/p2p/mux/stream_state.go

sei-tendermint/light/rpc/client.go

pompon0 · 2026-02-10T06:38:38Z

sei-tendermint/test/e2e/app/app.go

@@ -215,7 +215,7 @@ func (app *Application) FinalizeBlock(_ context.Context, req *abci.RequestFinali
 					},
 					{
 						Key:   []byte("height"),
-						Value: []byte(strconv.Itoa(int(req.Height))),
+						Value: []byte(strconv.FormatInt(req.Height, 10)),


huh, how is this better?

It is better because, Itoa literally calls FormatInt under the hood. The issue is correctness:

req.Height is int64. The original code does strconv.Itoa(int(req.Height)), which casts int64 → int. On 64-bit platforms int is 64 bits so this is fine, but int is only guaranteed to be platform-sized; on a 32-bit platform it's 32 bits, and that cast silently truncates any height above ~2.1 billion. FormatInt takes int64 directly, so there's no cast and no truncation risk.

Even if this will never run on 32-bit in practice, the cast is doing nothing useful; it's an extra conversion that only exists because Itoa takes int instead of int64.

Simply put, FormatInt is the right function when you already have an int64.

pompon0

LGTM for code in sei-tendermint dir.

Flatten sei-tendermint go mod into sei-chain

fb1c185

Flatten the sei-tendermint go module into sei-chain tin reduce dependency management complexity and error-prone multi layer replace directives. Part of PLT-6

masih added the app-hash-breaking label Feb 6, 2026

masih added 15 commits February 6, 2026 10:09

Remove dedicated tendermint CI job, coverage report and docker copy

63e2aa9

Fix gofmt issues

4fbe4b3

Remove redundant tooling dependency

ee17826

Fix invalid path to mockery generator

ef8057d

Use err.Is to assert error type in light client test

cc5bc21

Reduce test flakiness of TestSubscribeNewHeads

521fa5e

Fix lint issues take 2

2aec8f4

* errcheck: 50 * goconst: 1 * goimports: 3 * gosec: 50 * ineffassign: 2 * misspell: 2 * prealloc: 17 * staticcheck: 45 * unconvert: 1

Merge branch 'main' into masih/go-mod-tm-flattened

6974eb5

Fix remaining lint issues

efa207d

go work sync

548d60c

Fix nil check for self remediation config validation

9bc928b

Fix defer in loop and clean up cosmos go mod

89885f4

Fix more lint issues

f3984c4

Merge branch 'main' into masih/go-mod-tm-flattened

7e06782

Upgrade golangci lint

321d417

Fix imports

c6eb229

masih requested review from arajasek, sei-will and stevenlanders February 9, 2026 22:00

masih marked this pull request as ready for review February 9, 2026 22:00

pompon0 self-requested a review February 10, 2026 05:39

pompon0 reviewed Feb 10, 2026

View reviewed changes

sei-tendermint/internal/mempool/tx.go Outdated Show resolved Hide resolved

pompon0 reviewed Feb 10, 2026

View reviewed changes

sei-tendermint/internal/p2p/mux/stream_state.go Outdated Show resolved Hide resolved

pompon0 reviewed Feb 10, 2026

View reviewed changes

sei-tendermint/light/rpc/client.go Show resolved Hide resolved

pompon0 reviewed Feb 10, 2026

View reviewed changes

pompon0 approved these changes Feb 10, 2026

View reviewed changes

masih added 2 commits February 10, 2026 11:08

Revert +1 styling, cap max indices and add type assertion

72cf1a5

Remove duplicate type assertion

7d3a9b4

sei-will approved these changes Feb 10, 2026

View reviewed changes

arajasek approved these changes Feb 10, 2026

View reviewed changes

Flatten sei-tendermint go mod into sei-chain #2817

Are you sure you want to change the base?

Flatten sei-tendermint go mod into sei-chain #2817

Uh oh!

Conversation

masih commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codecov bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

masih Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

masih Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pompon0 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Flatten `sei-tendermint` go mod into `sei-chain` #2817

Flatten `sei-tendermint` go mod into `sei-chain` #2817

github-actions bot commented Feb 6, 2026 •

edited

Loading

codecov bot commented Feb 6, 2026 •

edited

Loading

codecov bot commented Feb 9, 2026 •

edited

Loading

masih Feb 10, 2026 •

edited

Loading

masih Feb 10, 2026 •

edited

Loading