CompositeStateStore Part 6: StateStore legacy db #2792
+1,543
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/composite-ss-read-path #2792 +/- ##
===================================================================
+ Coverage 48.32% 56.77% +8.45%
===================================================================
Files 671 2070 +1399
Lines 50580 168610 +118030
===================================================================
+ Hits 24443 95733 +71290
- Misses 23998 64348 +40350
- Partials 2139 8529 +6390
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Kbhat1
force-pushed
the
feature/composite-ss-wal-integration
branch
from
b68f249 to
f5d8315
Compare
Kbhat1
force-pushed
the
feature/composite-ss-legacy-db
branch
2 times, most recently
from
2d1839f to
24a9eae
Compare
yzang2019
reviewed
Feb 6, 2026
yzang2019
reviewed
Feb 6, 2026
Base automatically changed from
feature/composite-ss-wal-integration
to
feature/composite-ss-read-path
February 9, 2026 20:57
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
472
to
476
| for version, evmChanges := range evmChangesByVersion { | ||
| if err := s.evmStore.ApplyChangesetParallel(version, evmChanges); err != nil { | ||
| s.logger.Error("failed to flush EVM raw import batch", "version", version, "error", err) | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Contributor
Author
|
@yzang2019 could you review again? |
Comment on lines
165
to
171
| for storeType, pairs := range changes { | ||
| ch, ok := s.asyncChs[storeType] | ||
| if !ok || len(pairs) == 0 { | ||
| continue | ||
| } | ||
| ch <- dbWrite{version: version, pairs: pairs} | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Comment on lines
262
to
265
| for st, ch := range s.asyncChs { | ||
| close(ch) | ||
| delete(s.asyncChs, st) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
| ch := make(chan dbWrite, asyncBufferSize) | ||
| store.asyncChs[storeType] = ch | ||
| store.asyncWg.Add(1) | ||
| go store.asyncWorker(db, ch) |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
Kbhat1
force-pushed
the
feature/composite-ss-legacy-db
branch
2 times, most recently
from
03beace to
6c1c6aa
Compare
Kbhat1
force-pushed
the
feature/composite-ss-read-path
branch
from
fd3d4c8 to
12de207
Compare
Kbhat1
force-pushed
the
feature/composite-ss-legacy-db
branch
from
6c1c6aa to
57a6b04
Compare
Part 6 of CompositeStateStore: adds catch-all LegacyDB so ALL EVM data is routed to EVM-SS. - EVMKeyLegacy: catch-all for EVM keys that don't match optimized types (address mappings, codesize, receipts, pointers, bloom, etc.) - CodeSize routes to Legacy (not its own DB) per reviewer feedback - Rename EVMKeyUnknown → EVMKeyEmpty (only for zero-length keys) - Rename StoreUnknown → StoreEmpty - Malformed keys route to Legacy instead of being dropped - Updated all tests for new routing behavior
Kbhat1
force-pushed
the
feature/composite-ss-legacy-db
branch
from
57a6b04 to
6ade865
Compare
yzang2019
approved these changes
Feb 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Add a catch-all
LegacyDBto EVM-SS that stores all EVM module keys that don't fit into the optimized databases (Nonce, CodeHash, Code, Storage).This ensures ALL EVM data is routed to EVM-SS:
Testing performed to validate your change