Feature/page view adding segment properties

[wethu]

Hey People,

We're changing the properties tracked along with page views. I have some implementation here which works, however I'm having trouble stubbing the properties passed into page.

Thanks!

[hankim813]

@wethu Cool! Thanks for the PR. I'm guessing this is all backward compatible, augmentative data for our mutual customers (so we can just roll out to everyone at once)?

[hankim813]

page.properties() returns the current page call's properties object. By default our .page() call collects some context page metadata:

{
	      "path": "/context.html",
	      "referrer": "http://localhost:9876/?id=70213249",
	      "search": "",
	      "title": "",
	      "url": "http://localhost:9876/context.html"
	    },

☝️ is what gets set inside the test suite. So you should change the analytics.called() method to include these properties!

[wethu]

Thanks for that,

I was able to fix the problem by passing in the referrer to #page(), this means the example will always have the same id parameter.

Let me know if theres a better way to accomplish this!

[codecov-io]

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master     #6   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          28     28           
=====================================
  Hits           28     28

Impacted Files	Coverage Δ
lib/index.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 103b482...8e0e857. Read the comment docs.

[wethu]

@hankim813 Thanks for the review!

I'm currently triple checking with our Project Manager about the backwards compatibility aspect. And will follow up soon!

Thanks again :)

[SegmentDestinationsBot]

Hi @wethu, as part of the monorepo migration, this issue has been moved to new issue. Our engineers have been notified and will prioritize and work on it ASAP. Thank you!

For more information, see README.md.