Conversation
…auto-selection Setting the follow-up question auto-approve timeout to 0 now skips the countdown entirely instead of being clamped to the 1s minimum, so the first suggested answer is never auto-selected and the user always chooses manually. - FollowUpSuggest: short-circuit when timeoutMs <= 0 (set countdown null, still notify onCancelAutoApproval on unmount). - AutoApproveSettings: slider min 1000 -> 0; show a dedicated zero-state description when the value is 0. - Add timeoutZeroDescription across all 18 locales (reusing existing Roo translations). - Add FollowUpSuggest tests covering zero and negative timeout (no countdown, no auto-selection, cancel still fires on unmount).
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (21)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📜 Recent review details🧰 Additional context used📓 Path-based instructions (5)For persisted settings, verify the complete schema/storage/runtime/webview round trip, shared default semantics, and focused true plus false/unset tests.⚙️ CodeRabbit configuration file Files:
Require regression coverage at the lowest valid harness with behavior-focused assertions, including relevant negative, error, false/unset, and boundary cases.⚙️ CodeRabbit configuration file Files:
Check strict typing and exhaustive behavior across normal, boundary, error, cancellation, retry, and compatibility paths.⚙️ CodeRabbit configuration file Files:
Check React state and effect dependencies, cleanup, accessibility, i18n, and light/dark theme behavior.⚙️ CodeRabbit configuration file Files:
Act as an adversarial second-opinion reviewer.⚙️ CodeRabbit configuration file Files:
🪛 GitHub Check: mutation-diffwebview-ui/src/components/chat/FollowUpSuggest.tsx[warning] 66-66: Mutation test advisory [warning] 65-65: Mutation test advisory webview-ui/src/components/settings/AutoApproveSettings.tsx[warning] 323-323: Mutation test advisory [warning] 322-322: Mutation test advisory [warning] 321-321: Mutation test advisory 🔇 Additional comments (1)
📝 SummarySummary by CodeRabbit
WalkthroughThe follow-up auto-approval timeout can now be set to zero. Zero or negative timeouts disable automatic suggestion selection, and localized settings explain the zero-timeout behavior. ChangesFollow-up auto-approval timeout
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to The zero setting remains intact and prevents automatic selection. No actionable merge-blocking issue remains after normal checks. 🚥 Pre-merge checks | ✅ 7 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (7 passed)
Full details: Regression EvidenceExplanation The PR adds a durable visible settings state, but no Playwright component snapshot covers it. Resolution Add a Playwright component visual case whose fixture enables
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Review statusThanks for contributing. This comment tracks the review sequence and the next action. Current step: Awaiting fresh human maintainer or CODEOWNER approval. Automated review is complete for the latest commit but does not replace human approval. Review-state labels are managed by this workflow; do not edit them manually. |
github-actions
Bot
added
coderabbit-review-active
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
github-actions
Bot
added
awaiting-maintainer
This branch has not been deployed
1 participant
Related GitHub Issue
Internal pre-flight PR on the fork. Will be linked to the approved upstream issue when submitted upstream.
Description
Allows the follow-up question auto-approve timeout to be set to 0 to disable auto-selection entirely.
FollowUpSuggest: short-circuits whentimeoutMs <= 0(countdown set to null; still notifiesonCancelAutoApprovalon unmount).AutoApproveSettings: slider minimum lowered from1000to0; dedicated zero-state description when the value is 0.timeoutZeroDescriptionacross all 18 locales (reusing existing Roo translations).FollowUpSuggesttests covering zero and negative timeout.Reviewers should note the changed slider minimum and the new zero-state copy.
Test Procedure
cd webview-ui && npx vitest run src/components/chat/__tests__/FollowUpSuggest.spec.tsxPre-Submission Checklist
Documentation Updates
Additional Notes
The 0 value is a deliberate "disabled" sentinel; positive values keep the previous countdown behavior.
Get in Touch
Discord: seeones