Migrate some internals to typescript#418
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 20e1057 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
askoufis
previously approved these changes
Jun 3, 2025
askoufis
reviewed
Jun 4, 2025
Comment on lines
-1
to
+4
| // eslint-disable-next-line import-x/no-unresolved | ||
| import useScope from '__PLAYROOM_ALIAS__USE_SCOPE__'; | ||
| import React, { createElement, Fragment } from 'react'; | ||
| import scopeEval from 'scope-eval'; | ||
|
|
||
| import useScope from '../../useScope'; |
Contributor
There was a problem hiding this comment.
Turns out the useScope entrypoint was never actually used at all, but now it is.
michaeltaranto
approved these changes
Jun 4, 2025
Merged
This was referenced Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are based on the work from #313 (tysm @TheMightyPenguin 🙏). Splitting out this work into multiple new PRs for ease of reviewing and to be based off fresher code.
This first PR focusses on migrating the top level
srcfiles to Typescript, and any dependant files where required.NB: The
loadPlayroomfunction will now clear code immediately after loading if noinitialCodeargument is provided. This is to ensure saved code fromindexedDBdoesn't conflict with test expectations.