This repository was archived by the owner on Jul 15, 2025. It is now read-only.
Multiple APDU filters shall be combined per OR operation#1
Open
ghost wants to merge 1 commit intoandroid-5.0.0_r3-scapifrom
unknown repository
Open
Multiple APDU filters shall be combined per OR operation#1ghost wants to merge 1 commit intoandroid-5.0.0_r3-scapifrom unknown repository
ghost wants to merge 1 commit intoandroid-5.0.0_r3-scapifrom
unknown repository
Conversation
According to Secure Element Access Control specification, APDU filters shall be combined per OR operation if multiple access rules contain the different filters. The APDU access is not changed from the initial value "UNDEFINED" if the previous access rule has APDU filter, so new APDU filter shall be combined unless the APDU access is already set to "DENIED".
Author
|
The section 3.4.1 of Secure Element Access Control says; If multiple access rules contain APDU filters, then these shall be combined per OR operation. Actually putWithMerge() is implemented for that, but the condition is not good. Please imagine that there are the following 2 access rules detected. Both APDU filters must work in this case. - Access rule 1 contains an APDU filter A ApduAccess is still not changed to ChannelAccess.ACCESS.ALLOWED right after processing the access rule 1, so the APDU filter B is not merged mistakenly when processing the access rule 2 in the current implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to Secure Element Access Control specification, APDU filters
shall be combined per OR operation if multiple access rules contain the
different filters.
The APDU access is not changed from the initial value "UNDEFINED" if the
previous access rule has APDU filter, so new APDU filter shall be
combined unless the APDU access is already set to "DENIED".