Repository navigation
Conversation
…del, so it passes on GitHub's runners Step 15's conflict check looked for "cdevice=Mac" in the report. The cloud's save there is packed by the Mac's own session, and save_sync.c names its device with sysctl hw.model, which on GitHub's macOS runners is "VirtualMac2,1": the check failed in the host unit tests and the sanitizer jobs on every run, main's included (run 43326823244), while the report was right. The test now reads hw.model as save_sync.c does and looks for " cdevice=<model> ". Checked: make -C dm/host/tests GAME=010015100B514000 save-sync on a Mac18,5 (t_save_sync 112 checks, 0 failed; t_save_sync_metadata 209, 0 failed). No other test assumes a model name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
the
host
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
t_save_syncfails on every CI run, main's included (e.g. run 43326823244, jobs "Host unit tests and CPU-only gfx tests" and "Sanitizers"), at step 15:The check (
dm/host/tests/t_save_sync.c) looks forcdevice=Mac. The cloud's save there is packed by the Mac's own session, andsave_sync.c(device_name) names the device withsysctl hw.model, which on GitHub's macOS runners isVirtualMac2,1. The report is right; the test assumed a model name. The test now readshw.modelassave_sync.cdoes and looks forcdevice=<model>. No product code changes. No other test assumes a model name.This unblocks the host and sanitizer jobs for open PRs, #2246 among them.
Checked
make -C dm/host/tests GAME=010015100B514000 save-syncon an Apple-silicon Mac (Mac18,5):t_save_sync112 checks, 0 failed;t_save_sync_metadata209, 0 failed. The runner's model is checked by this PR's CI.🤖 Generated with Claude Code