Skip to content

t_hid follows the PRAGMATA port (it no longer links on main) - #2396

Closed
lunks wants to merge 1 commit into
seedds:mainfrom
lunks:pr/test-gaps
Closed

lunks wants to merge 1 commit into
seedds:mainfrom
lunks:pr/test-gaps

Conversation

@lunks

@lunks lunks commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

What and why

ccd834e0 (PRAGMATA port) gave hle_hid.c the DM_CTL commands atrace, addr and bufsnap, which call probe_atrace, dm_gfx_addr_note and dm_gfx_bufsnap. t_hid links hle_hid.c without the graphics host, so on main make -C dm/host/tests GAME=<id> run stops with three undefined symbols. The three get stubs next to the other dm_gfx_* ones.

This PR also had the t_codec_video half (the h_cv_*init2 overloads' new csd, csd_n arguments); #2240 (09a91c5) fixed that in the same way, so it is dropped here.

Tests only: no host code changes.

Checked

  • Tests: on origin/main (09a91c5), make -C dm/host/tests GAME=0400486024DEC000 build/t_hid fails with the three undefined symbols; with the change t_hid prints "251 checks, 0 failed".
  • Games run: none (tests only).
  • Devices and OS: M5 Pro, macOS 27.0.
  • Not checked: the rest of the host suite on this base; iOS.

Docs

  • No reference entry needed (test fix); the host and shader chain are unchanged
  • No game files, keys or data extracted from a game in the change or the attachments

@github-actions github-actions Bot added the host The Horizon host: SVCs, services, threads, memory (dm/host) label Nov 11, 2026
…ufsnap and probe_atrace (hle_hid.c's new DM_CTL commands call them; t_hid links without the graphics host)
@lunks lunks changed the title t_hid and t_codec_video follow the PRAGMATA port (they no longer link or compile on main) t_hid follows the PRAGMATA port (it no longer links on main) Nov 12, 2026
@lunks

lunks commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

Closing: 247f026 added the same three stubs to t_hid.c, so this is no longer needed.

@lunks lunks closed this Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

host The Horizon host: SVCs, services, threads, memory (dm/host)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant