Repository navigation
Conversation
…ufsnap and probe_atrace (hle_hid.c's new DM_CTL commands call them; t_hid links without the graphics host)
Contributor
Author
|
Closing: 247f026 added the same three stubs to t_hid.c, so this is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
ccd834e0(PRAGMATA port) gavehle_hid.cthe DM_CTL commandsatrace,addrandbufsnap, which callprobe_atrace,dm_gfx_addr_noteanddm_gfx_bufsnap.t_hidlinkshle_hid.cwithout the graphics host, so on mainmake -C dm/host/tests GAME=<id> runstops with three undefined symbols. The three get stubs next to the otherdm_gfx_*ones.This PR also had the
t_codec_videohalf (theh_cv_*init2overloads' newcsd, csd_narguments); #2240 (09a91c5) fixed that in the same way, so it is dropped here.Tests only: no host code changes.
Checked
make -C dm/host/tests GAME=0400486024DEC000 build/t_hidfails with the three undefined symbols; with the changet_hidprints "251 checks, 0 failed".Docs