Repository navigation
tools/settings: the upscaling settings say where they act - #2388
Open
roandegraaf wants to merge 5 commits into
Open
roandegraaf wants to merge 5 commits into
roandegraaf wants to merge 5 commits into
Conversation
DM_UPSCALER=metalfx takes an upscaler whose colour is a square root: the profile key upscaler_sqrt names it, its input is squared into MetalFX's (0400486024DEC000: 1.12 ms of GPU a frame to about 0.1). The upscale step of agl_ndsr_vr_light.pck samples colour the dispatch before it stored as square roots and writes v * |v|, so its code has no sRGB curve for the classifier and the option replaced nothing. DM_NVN_SKIP_CS (diagnostic) drops named compute dispatches, to measure one inside an encoder.
Upscaler sharpness (DM_UPSCALER_SHARPNESS, the profile's upscaler_sharpness): MetalFX's picture blended with a bilinear one of the same input, 0.7 for 0400486024DEC000, whose eight square-root upscale variants are named. MetalFX's spatial scaler has no strength setting and is crisper than agl's networks. The draw of its result into the game's image blends in the scaler's input, sampled bilinearly, by 1 - sharpness; 1.0 (every other game) is the picture as before. Front-ends: new: the settings list has DM_UPSCALER_SHARPNESS (range 0.0-1.0, shown while DM_UPSCALER is metalfx, default from the game profile)
0400486024DEC000's notes: six of the eight named upscale variants seen in play, by input size, and drawn by MetalFX; no other variant dispatched in eight situations.
The sharpness setting is named after its parent in the launcher: Game's upscaler sharpness.
The launcher's upscaling settings say where they act: Screen upscaling (DM_PRESENT_UPSCALE), 3D upscaler (DM_UPSCALER) and 3D upscaler sharpness, each with a line under it. "Upscaling" and "Game's upscaler" side by side, both offering MetalFX, did not tell a player which is which. Labels, notes and the player's page only; no variable, value or default changes. Front-ends: interface: the labels of DM_PRESENT_UPSCALE, DM_UPSCALER and DM_UPSCALER_SHARPNESS in the settings list changed, and DM_UPSCALER has a note now
roandegraaf
force-pushed
the
setting-names
branch
from
November 12, 2026 14:07
bbc643e to
b7de2da
Compare
github-actions
Bot
added
nvn
2 of 3 tasks
roandegraaf
changed the title
Kayyluhh
added a commit
to Kayyluhh/nxnative
that referenced
this pull request
Nov 14, 2026
… act (Screen upscaling, 3D upscaler)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2366 (it renames that PR's new slider too); the diff shows that PR's commits until it merges. The last commit is this change.
Rebased on main at 034e91a (2026-11-12), with #2366 rebased under it; this commit applied without conflicts, and no old label is left on main.
What and why
A game with its own upscaler shows two settings next to each other, Upscaling and Game's upscaler, both offering MetalFX, and with #2366 a third, Game's upscaler sharpness. A player could not tell which is which (asked by one, with a screenshot of the three rows).
DM_PRESENT_UPSCALEDM_UPSCALERDM_UPSCALER_SHARPNESSLabels, notes,
docs/settings.md(headings, anchors, table) and the comments that quote the labels. No variable, value, default or condition changes.One thing to judge:
settings.tsvsays a note is only for a setting with a cost. The 3D upscaler's note is there because its cost is the look, and without it the two MetalFX choices read alike.Checked
test_docs.py(links and anchors),test_settings.py,test_game_profile.py,test_env_switches.py. Run again after the rebase: all pass; host build.Front ends
Front-ends: interface:the labels ofDM_PRESENT_UPSCALE,DM_UPSCALERandDM_UPSCALER_SHARPNESSin the settings list changed, andDM_UPSCALERhas a note now.Docs
docs/settings.mdhas the new names;python3 dm/tools/docs_symptoms.pywas run