Repository navigation
bf16 half pairs (HFMA2.BF16_V2, HMNMX2.BF16_V2) and HMNMX2.NAN translate (chain change) - #2060
Open
Know-It-All-Brother wants to merge 3 commits into
Open
Know-It-All-Brother wants to merge 3 commits into
Know-It-All-Brother wants to merge 3 commits into
Conversation
…re_orin.py runs about 190 operations, each the GPU compiler's own machine code for one PTX operation, through the translator, spirv-cross, the chain's MSL rewrites and Metal on this Mac's GPU, and compares every output word with what a Jetson Orin (sm_87) computed from the same 1,024 input rows. The translator tests checked the MSL a few encodings give, not the values; this one finds the FSETP.NE, SHFL lane, F2FP, rounding-mode and signed-zero differences the tracking issue lists, which KNOWN names until each fix takes its entry out. dm/gfx/tools/ampere_orin/capture.py records the fixture on any Linux machine with an Ampere GPU and NVIDIA's driver, with no toolkit or compiler on either side
…ules with its functions, so a rewrite that uses one (struct in PR seedds#1902's hfma_msl) runs as it does in a build instead of raising NameError
…he Orin's results: the half-pair emitters only unpacked and packed f16 lanes and HMNMX2 had no NaN mode, so the translator refused all three. A bf16 lane now unpacks to its f32 with a shift or a mask, HFMA2 computes it with an f32 FMA and rounds it to bf16 with integer arithmetic (ties to even, a NaN gives 0x7fff), HMNMX2.BF16_V2 compares its lanes as integers so fast math can't fold it and -0 orders below +0 as on the Orin, and with .NAN a NaN in either operand gives 0x7fff in that lane; HMNMX2 .F32 and .XORSIGN and HADD2 / HMUL2 .BF16_V2 stay refused. compare.py counts a bf16 lane's denormals as Metal's f32 flush, since bf16 has f32's exponent. test_dmsh_ampere_orin.py: hmin2_nan, bmin2 and bmax2_nan went from refused to 0 of 2,048 lanes differing, bfma2 to 31 of 2,048, all flushed bf16 denormals, and all four are out of KNOWN; chain 7b4846c830cd
Know-It-All-Brother
added a commit
to Know-It-All-Brother/nxnative
that referenced
this pull request
Nov 9, 2026
…branch's translator rebuilt from its own source; chain ba6861aa2b18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the Ampere accuracy series (#2040). It depends on #2041 for the test: the commits before this PR's own are #2041's and drop out once it lands, so this PR's own change is the last commit.
What and why
Three half-pair forms failed to translate: HMNMX2
.NAN(min.NaN.f16x2), and the bfloat16 forms HMNMX2.BF16_V2(min/max.NaNonbf16x2) and HFMA2.BF16_V2(fma.rn.bf16x2). The half-pair helpers only knew f16 lanes. The fields from the Orin's encodings are.NANat bit 81 and.BF16_V2at bit 85.bits << 16(low) andbits & 0xffff0000(high), and pack by rounding to nearest even with integer operations. A NaN packs to0x7fff, as the Orin writes it whatever its sign..NAN, one NaN gives the other operand and two give NaN; with.NAN, any NaN gives NaN..NANon f16 keeps the existing min / max and overrides a lane with NaN where an operand is NaN. It doesn't collide with FMNMX and HMNMX2 order -0 below +0, as the GPU does (chain change) #2047's ±0 change..BF16_V2, which PTX only offers on sm_90 so the fixture can't check them, and HMNMX2.F32/.XORSIGN.These forms aren't hot. A bf16 FMA costs about 8 integer operations per lane for the rounding, and a bf16 min/max about 12.
A change to the test, which I want to be upfront about:
compare.pynow treats a bf16 denormal like an f32 one. Metal computes bf16 in f32, so it flushes bf16 denormals just as it flushes f32 ones. All 31 lanesbfma2still differs in are of that kind (for example inf × the bf16 denormal 0x0001 is inf on the Orin and NaN on Metal). The change only reclassifiesbfma2andf2fp_pack_bf16x2, which is still listed. If you'd rather not widen the rule,bfma2can go back intoKNOWNwith the reason "bf16 denormals flushed by Metal".Reference entry: "bf16 half pairs and HMNMX2.NAN" in
docs/reference/shaders.md.How to verify
hmin2_nanbmin2bmax2_nanbfma2All four come out of
KNOWN. The bf16 FMA computes in f32 and then rounds to bf16, which is two roundings. A model of that matches all 1,533 finite fixture lanes, but a case where the f32 result lands exactly on a bf16 tie that the exact result wasn't on would round wrong, and the fixture has none.Checked
test_dmsh_ampere_orin.py; every othertest_dmsh_*gives the same result as on main (test_dmsh_ampere_mem.py,test_dmsh_meshstage.pyandtest_dmsh_pairs.pyfail on main the same way);test_nsp_chain.py,test_xlate_anycpu.py,test_docs.py.lint_python.pyshows no new findings.tool_lock.py --update-lockanddmsh_chain.py --headerwere run (chain 7b4846c830cd).regress.py: not run. My only local Switch 2 build's shader package comes from an older shader split than main's map, so main's chain can't build it. Ocarina of Time's build already translates every shader, so it can't contain this instruction.Docs
docs/reference/shaders.mdhas the entry, andpython3 dm/tools/docs_symptoms.pywas rundmsh_chain.py --headerwas run, anddmsh_chain.h, the translator dlls and the lock are part of the change