Repository navigation
Conversation
bmjask
marked this pull request as ready for review
November 9, 2026 01:17
Contributor
|
For comparison: #1901 removes the same barriers by following the game's own |
bmjask
force-pushed
the
codex/nvn-bounded-compute-ordering
branch
from
November 9, 2026 13:49
d3143a3 to
a157107
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buffer-only compute dispatches currently insert a copy-encoder barrier even when their complete read/write ranges are disjoint. This opt-in change tracks those ranges and skips only independent barriers. RAW, WAR and WAW dependencies with copies/dispatches remain ordered; unknown, indirect, image, sparse, unresolved and overflowing bindings fall back conservatively.
Extracted from #1663, independently based on main
e3ad8255; no shader-chain change or image-quality reduction. Enable withDM_NVN_CS_RANGES=1, or useabfor existing A/B phases. Default remains off.Historical A/B evidence
November 8, Apple M4 Max, crowded Market; recovered from this campaign's chat and cross-checked against its saved JSON reports. These measurements are from the combined playability branch, not a fresh comparison of this extraction against current main.
The preceding 93.7/87.0 FPS pair had different clocks and is not a reliable gain/regression verdict. Source reports:
compute-range-review.json,heavy-market/predicated-cs-ranges-ab-02/ab-review.json,compute-range-full-gfx-result.json, andcompute-range-regress/report.md. The game note records scope and limitations.Validation
On this extracted change: 6,986 focused GPU checks pass in each direct/deferred encoder mode with Metal API validation; 11 documentation checks pass. Tests cover real copy/dispatch results, dependency directions, capacity and conservative fallback, not just implementation counters.
Historical full graphics and local Ocarina regression passed on the combined source; the regression ran at 60 FPS (59.5/59.5), so it is correctness coverage only. This extraction has not received a renewed full gameplay regression or five-game validation. Ocarina is the only local game; other titles and iOS are untested. The current playable app was not replaced. That validation and a current-main performance comparison remain outstanding.
Reproducible evidence
Tested extraction:
d3143a345fef9fd9ca79b263911203d38cd4d562. Test source at that commit; game note at that commit. Run on an Apple-silicon Mac with the repository's build dependencies configured:Saved local test-output excerpt (not a new test run or a CI result):
Historical A/B figures above describe the older combined branch. They are not fresh performance validation of this extracted commit. The remaining gameplay/regression limitations above still apply.
Rebase validation — 2026-11-09
Current head:
a157107714b58f7a1d1baf3e5946d546a8c9bded, one commit above upstream9983d659e6101867215e4afe5dd6287ad8e0d4a3.Full graphics check list: 126 test targets plus the two Python check targets passed on rerun. The focused compute fixture passed 6,986 checks in each encoding mode. An initial feedback timestamp assertion failed intermittently; the exact assertion also reproduced on unchanged upstream e121931, so this remains an upstream test limitation.
Mac fixtures were tested before the final upstream iOS-linker-only commit; verified that
dm/ios/tools/gen_build.pyis the sole subsequent file difference. Impact analysis was also run. No new gameplay A/B performance claim: historical figures above still describe the combined branch. Full current-chain game rebuild and gameplay regression remain pending; only Ocarina assets are locally available, and other titles/iOS are untested. The installed app andcodex/ocarina-playabilitywere preserved.