Repository navigation
Read Nintendo Control NCA metadata and Edition Acd_1 icon from extracted dumps - #1562
Open
ishtiaq156 wants to merge 4 commits into
Open
ishtiaq156 wants to merge 4 commits into
ishtiaq156 wants to merge 4 commits into
Conversation
ishtiaq156
marked this pull request as ready for review
November 6, 2026 20:25
This was referenced Nov 6, 2026
ishtiaq156
marked this pull request as draft
November 6, 2026 23:00
ishtiaq156
marked this pull request as ready for review
November 8, 2026 04:39
Retain official extracted Control NCA titles and icons, including the selected Ounce Program 1 Acd_1 identity, while incorporating upstream dump and documentation changes without conflicts. Checked: 73 focused dump/NUP/docs, 74 Mac/alias/workdir, and 8 previously failing environment/Xcode tests, plus Python compilation and regenerated symptoms index. No new game build or gameplay run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Apps built from extracted-folder dumps could show the dump directory name, an unknown display version and a missing icon even when original Control NCA metadata existed. For Switch 2 Editions,
control/Acd_1can contain a different, Edition-specific title and icon from the original game'scontrol/data.Import existing extracted
control/control.nacpand localizedcontrol/icon_*.datinto the packer's standardcontrol.nacpandicon.jpgoutputs. Prefer theAcd_1Control identity for selected Ounce (0400) programs when available, then standard Control and existing loose metadata. Prefer the American English icon, fall back to another locale, and remove stale metadata when its source disappears. Both full packaging and the preliminary survey use the same selection.This complements but does not duplicate #1253, which selects extracted
program/<n>layouts; this PR chooses metadata after a program folder is selected. It is also separate from #1551's manual icon override. The general cause and fix are documented in the packing reference.Checked
main; 74/74 nearby Mac, alias and work-folder tests passed. Eight previous CI-failing environment-switch and Xcode-workflow tests also passed. Python compilation, regenerated symptoms index and Git whitespace checks passed.040015100B514001, updatev327680with Bellabel DLCv131072, used its officialAcd_1title and icon in a local Mac build. Gameplay validation for that build used a separate BFRES diagnostic overlay. This metadata-only refresh had no new game build or gameplay run.Docs
docs/reference/packing.mdand regenerateddocs/agents/symptoms.md.