Repository navigation
SDK 21 virtual output device properties and event-only stream open (Wonder Edition movie) - #1561
Closed
ishtiaq156 wants to merge 5 commits into
Closed
ishtiaq156 wants to merge 5 commits into
ishtiaq156 wants to merge 5 commits into
Conversation
…or Wonder's movie
github-actions
Bot
added
host
ishtiaq156
marked this pull request as ready for review
November 6, 2026 20:24
This was referenced Nov 6, 2026
ishtiaq156
marked this pull request as draft
November 6, 2026 23:00
ishtiaq156
marked this pull request as ready for review
November 8, 2026 04:39
This was referenced Nov 10, 2026
FifteenPen
added a commit
to FifteenPen/nxnative
that referenced
this pull request
Nov 10, 2026
… it), seedds#1921 on main as 30c9b16, seedds#1561 explained (aborts after the safety screen without it), its six refused shaders built by seedds#2264
Retain the SDK 21 virtual output properties and event/no-flags OpenOutputStream hooks without touching the existing audio sample path. The newer upstream documentation and host changes merge without conflicts. Checked: five focused native audio binaries, documentation tests, prior CI environment-switch regression test and regenerated symptom index. This sync did not rerun Wonder gameplay.
seedds
added a commit
that referenced
this pull request
Nov 12, 2026
…ream open without flags and the release of the output device notification, so Nintendo Switch Sports Resort no longer aborts in GetVirtualOutputDeviceProperties (PR #2380): unhooked, the SDK connected to auddmg:u, which the host does not serve, and aborted with 0xa99 (sdk+0x224d1c) right after GetDefaultVirtualOutputDevice. nn::audio::VirtualDeviceProperties is 0x110 bytes, filled by audio::detail::GetVirtualOutputDeviceProperties from the device manager's profile (the game's sdk+0x224cd4): the name asked about, at +0x100 the shortest stream as a duration in ns (OutputStreamImpl::Open refuses a capacity under ceil(it x rate / 1e9) frames with 0x899, sdk+0x225a94..0x225ad0, checked here) and at +0x108 a word nothing in the sdk reads (0). The host answers its one device with a 10 ms minimum (one period, what Xenoblade Chronicles 2 and Star Fox write per block), and any other name with a red line and a failure. The OpenOutputStream overload with an event and no flags (main+0x5edb34) opens like the one with flags; ReleaseAudioOutputDeviceNotification (main+0x3af119c; the SDK's asks aud:u, unserved) destroys the event the host bound and clears the flag, so a later acquire binds again. Chosen over ishtiaq156's PR #1561 (the properties as the name and zeros, found on Super Mario Bros. Wonder) for the minimum duration read from the SDK and the release. Reference entries in audio.md, symptom index regenerated. Checked: t_output_stream (the properties, another device refused, the overload without flags) and t_audren_work (acquire, refused second acquire, release, acquire again), both pass. Co-authored-by: bymaxmarc <354601562+bymaxmarc@users.noreply.github.com>
Owner
|
Superseded by #2380, landed as 037b869: GetVirtualOutputDeviceProperties (its layout worked out from SDK 22) and the event OpenOutputStream overload without flags, plus the output device notification's release. It should cover Super Mario Bros. Wonder Nintendo Switch 2 Edition's OnlineSelect.webm too; that game was not run here. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Super Mario Bros. Wonder Nintendo Switch 2 Edition (Program 1, SDK 21, update
v327680) aborted withauddmg:uresult0xa99when opening itsOnlineSelect.webmmovie. The host already supplied a virtual output device, but it lacked the SDK 21GetVirtualOutputDevicePropertiesexport and the event-takingOpenOutputStreamoverload withoutOutputStreamFlag.Serve the properties of the existing
AudioVirtualOutputdevice (a 0x10c-byte result with a zeroed property tail), reject unknown names, and route the no-flags event overload to the existing AudioOut implementation. The audio sample path is unchanged. The general symptom, cause and fix are in the audio reference.This is independent of #1253's extracted Program 1 selection. Earlier SDK 21 OutputStream and hardware Opus support is already on
main(67f1d005).Checked
t_output_stream,t_audio,t_audio_spsc,t_audio_deviceandt_audio_statspassed on the updated upstream integration. The stream test covers the properties boundary, unknown device names, event/no-flags open, capacity/state and audio release.test_docspassed (6/6), the previous unrelatedtest_env_switchesCI failure passed (1/1),docs_symptoms.pyregenerated the index without changes, and Git whitespace checks passed.v327680+ Bellabel DLCv131072build reached multiple courses with movie playback and audio, but used a separate diagnostic BFRES memory overlay. This SDK 21-only refresh had no new gameplay or movie retest.Docs
docs/reference/audio.mdand the symptom indocs/agents/symptoms.md.