Repository navigation
Conversation
…keys: test_game_profile covers the other packs, so the keys of agl_ndsr_vr.pck and agl_ndsr_vr_light.pck are in the shader map test the way agl_ndsr.pck's are; UPSCALER_SOURCE documents that these are the upscaler's sources and points at where the option refuses a variant it cannot draw
This was referenced Nov 6, 2026
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1537 and #1547. Overlaps a little of #1459: it was written independently from that branch, and if #1459 takes this branch's test row or this takes #1459's regex line, either merge drops cleanly.
What and why
The launcher's Game's upscaler choice
DM_UPSCALER=metalfxlists onlyagl_ndsr.pck's compute shaders (UPSCALER_SOURCEindm/games/game.py), but a game's upscaler network ships inagl_ndsr_vr.pckandagl_ndsr_vr_light.pcktoo: The Legend of Zelda: Ocarina of Time (Switch 2) upscales withagl_ndsr_vr.pck'sfa3033d05c0a41d6and friends, which the option never offered, so switching to MetalFX left the game's network running and told the player nothing about it (DM_GAME_UPSCALER_KEYSwas empty on 0400486024DEC000).The same shotgun #1459 applies on its branch. This does not move the launcher: against #1459's current head it shows no
game.pydiff beyond the branch's own two comment lines, and the test change is not there at all (git show pull/1459/head:dm/tools/tests/test_game_profile.pyhas novr_lightrow).Checked
test_game_profile.pyon the change above main 339d9f2:MAPgains oneagl_ndsr_vr_light.pckrow (the pack Ocarina of Time'sFA3033D05C0A41D6comes from), andDM_GAME_UPSCALER_KEYSfor the fixture goes from 2 keys to 3 withDM_GAME_UPSCALER_N 3. The new row fails against main's/agl_ndsr\.pck#regex (fixture asserts 3 keys, gets 2) and passes with this branch's.test_game_profile7 tests,test_dmsh_hmma9, OK on 27.5.1 / M5 Max, Xcode 27.2.Docs
UPSCALER_SOURCE's comment indm/games/game.pystates where the option refuses a variant it cannot draw, nothing else.