Repository navigation
Conversation
…from loader.c since 2202d61 2202d61 made dm/host/loader.c call mtl_present_screen (nvn_mtl.m). t_nro.c and t_symbols.c include loader.c without linking nvn_mtl.m, so both stopped linking (Undefined symbols _mtl_present_screen) and the Sanitizers job of the tests workflow fails on every pull request. Each gets the same no-op stub the other host tests already have for the present. Checked: make -C dm/host/tests GAME=040074A01BF12000 build/t_nro build/t_symbols, then both run: OK.
github-actions
Bot
added
the
host
lunks
added a commit
to lunks/nxnative
that referenced
this pull request
Nov 6, 2026
dm/host/tests/Makefile: main's run line (t_net_eventfd first) with t_vi_display kept. t_vi_display needs a stub of mtl_present_layer, called from hle_vi.c since 2202d61, as t_nro and t_symbols needed one for mtl_present_screen (seedds#1454). Checked: make -C dm/host/tests GAME=040074A01BF12000 build/t_vi_display, then it runs.
Contributor
Author
|
Main has the same two stubs now (2eb7182), so this is covered; closing. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
2202d610madedm/host/loader.ccallmtl_present_screen(innvn_mtl.m).t_nro.candt_symbols.cincludeloader.cwithout linkingnvn_mtl.m, so both stopped linking:The
Sanitizers (ASan, UBSan and TSan …)job of the tests workflow runs them and fails on every pull request since (for example #1307). Each test gets the same no-op stub the other host tests already have for the present. #1444 carries the same two lines among its changes; this takes them alone so the check is green for everyone.Checked
make -C dm/host/tests GAME=040074A01BF12000 build/t_nro build/t_symbols, then both run: OK. The ASan build itself was not run here.Docs