Repository navigation
Parse NDVE network archives using declared member bounds - #1416
Open
givethesourceplox wants to merge 1 commit into
Open
givethesourceplox wants to merge 1 commit into
givethesourceplox wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Add a structured reader for NDVE v5 video-enhancement archives. The outer file contains parameter pairs, a separate NDSR pack and a trailing
1ALRarchive index. Searching for control-header magic can mistake weights or adjacent members for shaders and does not establish their bounds.Validate declared lengths, index and member extents, non-overlapping weight/control/code ranges, compute-stage control headers and matching code lengths. Recognize NDVE in both blob scanning and the loose-file prefilter, including compressed files. The embedded NDSR pack uses the existing reader; the NDSR odd-entry record walk remains separate in #1388.
Reference finding. Extracted from the Ocarina bring-up work in #1299; no game profile, assets or shader-chain changes are included.
Checked
Python 3.14 on macOS 26.5.2:
test_split_*.pysuite: 57 tests pass.git diff --checkpasses.dm/tools/tests/test_nso_match.py; its baseline was not widened.This reader's reach is NDVE files; no standalone game run or five-game harness report is claimed. No game shader rebuild was needed or performed, since the translation chain and existing shader libraries are unchanged. Full Ocarina bring-up still depends on #1299 and other open fixes.
Docs