Repository navigation
Star Fox: a Resolution setting scales its scene, and GameChat's virtual camera gets an off-screen native window so the avatar settings no longer crash - #1323
Open
WizardOfCodez wants to merge 2 commits into
Conversation
…al camera gets an off-screen native window so the avatar settings no longer crash - The rewriter's frame-step stub at main+0xb4498ac (build a7730d0f…) replaces the renderer's scene scale with DM_RESOLUTION_SCALE when it is set; the launcher offers it as "Resolution" (Game's own / 75% / 100%) for this build only. patch_nso.py gives frame-step code ctx.area(offset), a patch area in reach of the site, since main's text is 189 MB. - nn::chat::GetVirtualCameraNativeWindowHandle returns an off-screen native window instead of 0: the game makes an NVN window of it; such a window acquires at once and presents nowhere. - Probes: DM_PROBE_FP=1 logs s0-s15, and DM_PROBE_WATCH / DM_PROBE_POLL take as+<offset>. - The game note records the picture's cause chain (with seedds#1304 and seedds#1305), the measurements, and the Venom 2 out-of-memory that seedds#1310 removes.
…he docs no longer quote two switches nothing reads (DM_NVN_CUT_FIRST, an experiment's A/B switch never kept; DM_NVN_VC_WAYS, the switch2ios fork's)
WizardOfCodez
force-pushed
the
starfox-resolution
branch
from
November 5, 2026 17:50
02dac06 to
6326ad1
Compare
2 of 3 tasks
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
This builds on #1304 and #1305, which fix the small docked picture. It should merge after them; it does not need their code to build. #1310 (the copy absorb) is not part of it, but the play test below ran with it.
main+0xb4498ac(builda7730d0f…only) replaces that scale withDM_RESOLUTION_SCALEwhen it is set. The launcher offers it as Resolution (Game's own / 75% / 100%), gated on the build'sRESOLUTION_SCALEcapability. With 0, every instruction the game runs is its own.patch_nso.pygives frame-step codectx.area(offset): main's text is 189 MB, so a branch from the front patch area cannot reach the site.nn::chat::GetVirtualCameraNativeWindowHandlereturned 0. The game creates an NVN window from whatever handle it gets, so this crashed. The hook now returns an off-screen native window: the window initializes, acquires at once with its sync signalled, and presents nowhere. Reference entry:docs/reference/services.md(GameChat).DM_PROBE_FP=1logs s0–s15.DM_PROBE_WATCHandDM_PROBE_POLLtakeas+<offset>(relative to the guest address space base), so an address found in one run works in the next.Checked
make -C dm/host/tests GAME=0400E88025B1A000 runpasses (t_pctl: 67 checks, including the virtual camera window).make -C dm/gfx/tests GAME=0400E88025B1A000 check_t_nvnpasses (238, including the off-screen window).check_t_readbackpasses (173).test_docs.py,test_patches.py,test_settings.pyandtest_launcher_settings.pypass.regress.py check: not run. This Mac has no other games. The host changes reach only a game that asks GameChat for a virtual camera window, or that uses the new probe switches. The rewriter'sctx.areais used only by this profile's stub.Docs
docs/reference/services.md, andpython3 dm/tools/docs_symptoms.pywas run (the symptom index)