Repository navigation
Fix Python lint in work-folder cleanup tests - #1301
Closed
thehobbit85 wants to merge 1 commit into
Closed
thehobbit85 wants to merge 1 commit into
thehobbit85 wants to merge 1 commit into
Conversation
Owner
|
Closing as superseded: 58a77cc landed the same fix on main while this was open, and lint-python is green there. Your diagnosis of the three findings was correct, thanks. Its |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main commit 56bafa9 introduced three Pyright errors in the work-folder cleanup tests, so PR checks built on current main fail Python lint even when they do not change these tests. This fixes the test setup without changing production behavior or the lint baseline.
The CLI cleanup test uses a scoped patch for the dynamically loaded module's
NSP_FOLDER, restoring the setting afterward while retaining the success/failure and work-folder filtering assertions. The archive tests advance the observed clock by 30 days and use the normal integer quiet period, replacing the fractionaldaysargument and real sleep. The real archive, file, and extended-attribute assertions remain unchanged.Validation on main
7550be15acaae96e9a86c92e31cf8190975066bf:dm/tools/tests,dm/ios/tests, anddm/gfx/testsin a fresh native arm64 Python 3.14.6 process, with the committed translator and Xcode 27.2: 1,578 tests, no failures, 13 optional skips (9 Unicorn execution tests and 4 tests requiring native GPU executables).git diff --checkpasses. No host, shader-chain, or production-tool behavior changes; game regressions are inapplicable to this test-only repair. Remote CI is pending.This is a shared upstream repair, kept separate from feature PRs. It addresses different errors from #1294.