Repository navigation
Conversation
github-actions
Bot
added
tools
moretti
force-pushed
the
botw-enc-thread-mac
branch
from
November 3, 2026 06:54
8bb5f2d to
5bb1a75
Compare
The game waits on the fence of the frame it just submitted, so the submit thread's translation is part of its frame. With the profile's enc_thread on, an M5 Pro run (470 s outdoors) took the present thread's CPU from 5.9 to 3.4–4.4 ms a frame and the submit from 6.6 to 5.0 ms; iOS has it on already. The deferred encoder's stand-ins for the depth plane copies with blit options, which this needs, are on main (7d260ee).
moretti
force-pushed
the
botw-enc-thread-mac
branch
from
November 8, 2026 07:32
5bb1a75 to
c540ee8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #930 (3 of 4). The deferred encoder's stand-ins for the depth plane copies with blit options are already on
main(7d260ee), so this PR is only the profile key.Summary
dm/games/01007EF00011E000/game.tsv present_snap on pso_mtl4 on + enc_thread on # Metal encoding on its own thread on the Mac too (already on by default on iOS)The game waits on the fence of the frame it just submitted, so the submit thread's translation is part of its frame, and moving the encoding to its own thread shortens it.
docs/agents/game-patches.mdlists Breath of the Wild beside Need for Speed underenc_thread.test_launcher_settingsnow expects the Mac default to follow the profile: on for Breath of the Wild, off for Wonder.Evidence
check_t_rt_range(19 cases, the test 7d260ee fixed for the encode thread) passes with this profile.main: host and CPU gfx tests, sanitizers, tool tests, clang-tidy and ruff/pyright pass locally.Merge Danger
Door: two-way: one profile key.
Blast Radius: Breath of the Wild on the Mac.
regress.py impact: Breath of the Wild only. The game isn't on this machine any more, soregress.py checkwas not rerun on this branch; the measurements above are from #930's runs.