Repository navigation
docs: 🏗️ add Rust interface design for discard() - #246
lwjohnst86 wants to merge 15 commits into
Conversation
bf59dbb to
cf1aa0f
Compare
DanMazJen
left a comment
There was a problem hiding this comment.
Note sure I'm capable of reviewing the implementation here without actually sitting with the code in my own hands – but tried replying to one of the questions :)
Please take that with a grain of salt...
fa748d2 to
d75fb99
Compare
d75fb99 to
85b47c3
Compare
signekb
left a comment
There was a problem hiding this comment.
A couple of suggestions and a comment:
1b8b022 to
c161934
Compare
fruvago
left a comment
There was a problem hiding this comment.
A more in-depth review, taking the broader architecture as given.
f962f43 to
eda1ed9
Compare
5465113 to
1943f9d
Compare
signekb
left a comment
There was a problem hiding this comment.
I spent some time yesterday trying to write things out and that lead me to some questions, mostly about the Session struct:
| the current deposit on Zenodo needs to be retrieved, do `Session::new()` | ||
| again to start over. | ||
|
|
||
| `Session::require_deposit(self: &self) -> Result<Self, Error>` |
There was a problem hiding this comment.
| `Session::require_deposit(self: &self) -> Result<Self, Error>` | |
| `Session::require_deposit(self) -> Result<Self, Error>` |
To match the other change
There was a problem hiding this comment.
I think based on your previous comments, I'll revise this to be a check on if Session.deposit is empty or not, so we don't need another method
Co-authored-by: Daniel Mazhari-Jensen <120712445+DanMazJen@users.noreply.github.com>
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com> Co-authored-by: fruvago <57952344+fruvago@users.noreply.github.com>
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com> Co-authored-by: fruvago <57952344+fruvago@users.noreply.github.com>
4beb9e9 to
fdb9399
Compare
Description
Potential design for
discard(), along with signatures and descriptions of some library functionsNeeds a thorough review.
Kroki diagram preview here
Checklist
just run-all