Repository navigation
Hydromancer trades support - #185
Merged
Merged
Conversation
hacheigriega
force-pushed
the
feat/trades
branch
from
October 6, 2026 14:33
668db6f to
0b230d0
Compare
hacheigriega
changed the title
hacheigriega
force-pushed
the
feat/trades
branch
from
October 6, 2026 18:48
0b230d0 to
a2b860a
Compare
hacheigriega
marked this pull request as ready for review
October 6, 2026 19:02
Add support for trades type data for Hydromancer module. Set up a cache that filters out trades that are older than a configured time period upon receiving a request or a frame for that coin.
hacheigriega
force-pushed
the
feat/trades
branch
from
October 6, 2026 19:21
a2b860a to
4361473
Compare
Thomasvdam
approved these changes
Oct 8, 2026
Thomasvdam
left a comment
Thomasvdam
left a comment
Contributor
There was a problem hiding this comment.
Looks ok, but I'm missing why we want/need this? There's probably a Slack thread or Notion page somewhere but that's hard to find 😅
Contributor
Author
Monaco spec states
So simply to determine book quality based on current trade size. @Tommytrg could confirm :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Hydromancer module now supports the trades data type, allowing an OP to retrieve the trades executed within a configured time range.
Explanation of Changes
Set up a cache that filters out trades that are older than a configured time period upon receiving a request or a frame for that coin.
Note that since we process inbound frames outside Effect, the cache write calls retrieve the current time using
unsafeCurrentTimeMillis, which reads from the clock we install on the fiber.Testing
Added test cases
Related PRs and Issues
Related: #183