Repository navigation
ByBit one symbol per frame - #184
Merged
Merged
Conversation
The ByBit module now sends one symbol per subscribe or unsubscribe frame since ByBit rejects all symbols in the request if any of the symbols is invalid. This change also allows the module's `maxSymbolsPerRequest` to go above 10, which was set based on ByBit's limit on the number of arguments for its spot endpoint.
hacheigriega
force-pushed
the
feat/hydro-trade
branch
from
September 28, 2026 20:41
7e99ef4 to
8c4a447
Compare
hacheigriega
marked this pull request as ready for review
September 28, 2026 20:42
Thomasvdam
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Two problems:
maxSymbolsPerRequestat 10, which was set based on ByBit's limit on the number of arguments per request for its spot endpoint.Explanation of Changes
It seemed the simplest solution is to send one symbol per subscribe or unsubscribe frame. This also made sense given that ByBit does not rate limit on the number of messages.
Also includes a small commit that adds config check for duplicate module names.