Repository navigation
Convert Lighter to a ticker module - #181
Merged
Merged
Conversation
hacheigriega
force-pushed
the
refactor/lighter
branch
6 times, most recently
from
September 26, 2026 01:19
741b324 to
dc93026
Compare
hacheigriega
marked this pull request as ready for review
September 26, 2026 01:24
Thomasvdam
reviewed
Sep 28, 2026
hacheigriega
force-pushed
the
refactor/lighter
branch
from
September 28, 2026 14:41
b4ebf30 to
525209a
Compare
Thomasvdam
approved these changes
Sep 28, 2026
To accommodate Lighter's numeric market IDs, (un)subscribe keys and cache keys have been made generic. VenueWS also now takes `pongFrame` as an optional input since Lighter requires that client replies to periodic pings with pongs. Lighter module config now uses the shared ticker module fields (breaking change).
Parse inbound frames directly into `VenueParsedInbound`. Extract shared JSON record parsing and data-item mapping.
Add `streamType` to Lighter module config and add support for stream types `order_book` and `trade`.
hacheigriega
force-pushed
the
refactor/lighter
branch
from
September 28, 2026 15:12
525209a to
598bbdc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Incorporate Lighter module as a ticker module to reduce duplicate code.
Add support for stream types beyond just the
tickertype for Lighter module. While we will probably have to add support for multiple stream types (channels) per module, this is a start.Explanation of Changes
Commits in order:
Includes backward incompatible changes.
Related Issues
Closes: #149