feat(CSAF2.1): #302 add recommendedTest_6_2_20.js#463
Draft
feat(CSAF2.1): #302 add recommendedTest_6_2_20.js#463
Conversation
# Conflicts: # csaf_2_1/csafAjv.js
|
Coverage after merging 198-csaf-2.1-recommended-test-6.2.20 into main
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
rainer-exxcellent
left a comment
rainer-exxcellent
left a comment
There was a problem hiding this comment.
In test Recommended Test: Additional Properties (failing example 1)
the same error seams to be added twice
bendo-eXX
assigned
rainer-exxcellent and
bendo-eXX and unassigned
bendo-eXX and
rainer-exxcellent
Contributor
Author
This issue occurs because the csaf_2_1_strict/schema.json uses oneOf for cvss_v3. However, if the test file matches both schemas, both validations fail — resulting in two error messages. |
tschmidtb51
requested changes
Feb 13, 2026
Contributor
tschmidtb51
left a comment
tschmidtb51
left a comment
There was a problem hiding this comment.
Please see my comments.
*Note: CVSSv4 might change again - depending on @domachine investigation. I suggest to leave that PR for now and update once oasis-tcs/csaf#1287 is resolved.
Comment on lines
+195
to
+200
| baseScore: { $ref: '#/definitions/noneScoreType' }, | ||
| baseSeverity: { $ref: '#/definitions/noneSeverityType' }, | ||
| threatScore: { $ref: '#/definitions/noneScoreType' }, | ||
| threatSeverity: { $ref: '#/definitions/noneSeverityType' }, | ||
| environmentalScore: { $ref: '#/definitions/noneScoreType' }, | ||
| environmentalSeverity: { $ref: '#/definitions/noneSeverityType' }, |
Contributor
There was a problem hiding this comment.
This is not part of the CVSSv4!
| 'JSON Schema for Common Vulnerability Scoring System version 4.0, Revision 1', | ||
| $id: 'https://www.first.org/cvss/cvss-v4.0.1.json?20250704', | ||
| type: 'object', | ||
| additionalProperties: false, |
Contributor
There was a problem hiding this comment.
You can't use additionalProperties if there are multiple schemas involved.
Suggested change
| additionalProperties: false, | |
| unevaluatedProperties: false, |
| if (!validateStrictSchema(doc)) { | ||
| const additionalPropertiesErrors = | ||
| validateStrictSchema.errors?.filter( | ||
| (e) => e.keyword === 'additionalProperties' |
Contributor
There was a problem hiding this comment.
Please check whether that is still true for CVSSv4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/oasis-tcs/csaf/blob/master/csaf_2.1/prose/share/csaf-v2.1-draft.md#additional-properties