fix: normalize ContributeFooter route before GitHub link#446
Open
tansawit wants to merge 2 commits intosecurity-alliance:developfrom
Open
fix: normalize ContributeFooter route before GitHub link#446tansawit wants to merge 2 commits intosecurity-alliance:developfrom
tansawit wants to merge 2 commits intosecurity-alliance:developfrom
Conversation
Collaborator
|
Hey! Thanks for the effort you put into this.
Thanks again for the time and sorry you experienced issues in finding the pages on github 🙏🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
ContributeFooter.tsxURL generation to handle trailing slashes inwindow.location.pathname.Problem
Routes like
/intro/introduction/were being transformed intointro/introduction/.mdx, producing invalid GitHub links (for example.../intro/introduction/.mdx).Change
window.location.pathnameby trimming leading and trailing/./home route./intro/introduction/->intro/introduction.mdx.Validation
Frameworks PR Checklist
vocs.config.tsadding thedev: trueparameterFiles
components/footer/ContributeFooter.tsx