Draft
Conversation
Author
|
I decided it would be better to create a custom serde Serializer for this instead. I can either include the 'pretty' module directly in this repo, or add it to a fork of |
DrPresident
approved these changes
Aug 1, 2023
DrPresident
left a comment
DrPresident
left a comment
There was a problem hiding this comment.
Looks good from what I can tell, not super familiar with how this encryption works and I didn't scrutinize the pretty-printing in depth. Tests look good, would be nice to add one that actually verifies an ethereum permit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found an existing crate to transform the compact form of JSON string from serde-json-wasm into a "pretty" version, with an indent of 4 spaces. It's using String manipulations, so I don't think there are any floating point issues with this approach, but have not tested uploading this as a contract.