fix(skill): align author-saf-technique with the research validator - #232
Open
bishnubista wants to merge 1 commit into
Open
Conversation
bishnubista
force-pushed
the
fix/author-skill-validator-alignment
branch
from
September 4, 2026 04:16
e2e389f to
3d14485
Compare
Document the six prohibited_inputs fragments the validator requires for clean-room attestations and carry them in the blank template; correct the canonical traceability-ledger and detection-rule paths; reconcile the GHSA search instruction with clean-room discovery rules; replace the macOS-only frozen-bundle path with a portable scratch root, a single -rN retry convention, and fail-closed attempt-directory creation; fix "strict validator" wording and the --draft help string to match the validator's actual modes. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: bishnubista <bista.developer@gmail.com>
bishnubista
force-pushed
the
fix/author-skill-validator-alignment
branch
from
September 4, 2026 04:17
3d14485 to
3a455d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns the
author-saf-techniqueskill and the blank attestation template with whatscripts/validate-technique-research.pyactually enforces, and fixes one path and two portability problems in the clean-room instructions.What changed
prohibited_inputsfragments documented. The validator requires six exact substrings inprohibited_inputsforgeneration_mode: clean_room(validate-technique-research.py:519-530). Four of them were absent from the skill, andprevious conversationappeared nowhere in the skill or template, so an attestation written in the skill's own wording failed validation.references/clean-room-generation.mdnow lists the six strings verbatim, andresearch/templates/technique/clean-room-attestation.ymlcarries them as a commented block to uncomment when a packet is converted toclean_room(the standard-mode scaffold keeps its not-applicable placeholder, since those inputs are permitted in standard reruns).SKILL.mdlistedtraceability-ledger.ymlas a bare path among otherwise-complete canonical paths; it lives atresearch/techniques/SAF-TXXXX/traceability-ledger.yml.references/methodology.mdnow namestechniques/SAF-TXXXX/detection-rule.yml, the one packet artifact outside the research packet.references/breach-and-vulnerability-research.mdmandated a GitHub Security Advisories search thatclean-room-generation.mdforbids; the bullet now carries the clean-room exception (open an exact advisory URL only after non-GitHub discovery)./private/tmp/..., which does not exist on theubuntu-latestCI runner. It is now$SAF_CLEANROOM_ROOT, defaulting to${TMPDIR:-/tmp}/saf-all-cleanroom, and must resolve to an absolute path outside the checkout. Attempt directories are created fail-closed (plainmkdir, next-rNon collision) so stale or concurrent attempts cannot mix under oneFREEZE.sha256; freeze provenance is recorded in the bundle'sintegration-notes.yml. Retries and normalization re-freezes useSAF-TXXXX-rN; existing attestations had independently invented six different suffixes (-normalized,-retry,-r2,-retry3,-validator,-isolated).--strictflag exists; strict checking is the default and--draftdisables it. Wording now says "default (non---draft) mode." The--drafthelp string said it only skipped "completion statuses"; it now states which strict-only checks it relaxes (including accepting the placeholder zero history SHA) and that schema, cross-file joins, and core clean-room assertions remain enforced.Testing
python3 -m unittest discover -s scripts -p "test_*.py"— 15 tests, OKvalidate-technique-research.py --all,validate-framework-model.py,generate-technique-catalog.py --check,validate-detection-registry.py,generate-detection-coverage.py --check,generate-mitigation-catalog.py --check— all exit 0SAF-T1309'sprohibited_inputsin the skill's verbatim wording fails with fourprohibited_inputs missing ...errors; the unmodified packet passes.scripts/new-technique.pyproduces zero clean-room errors; the same scaffold converted toclean_roomper the documented procedure produces zeroprohibited_inputs missingerrors.