Write down what the green tests taught this cycle

[0kaba0]

Three rules for hosting-panels/common/tests/, each of which cost a real defect that a passing test did not see. Suggested in review of #93; the next hook will be written by someone who was not here for these.

A word being present is not a criterion

• test_pdns_restart.sh checked that pgrep -x pdns_server appeared in the installer. It does — in the backend detection, ten lines above the restart. Removing the liveness check left the test green.
• test_named_conf_edit.sh checked that named-checkconf appeared. It does — inside the message "Check: named-checkconf". Replacing the real guard with if true left the test green.

Both now assert the property: if named-checkconf gating the branch, a rollback restoring the backup, a did not come back message on the path where the service stayed down.

GNU extensions break silently on BSD

sed -i without an argument, \?, i\ with a leading tab — GNU-only. On macOS they do not fail, they produce different output: the old named.conf edit wrote talso-notify and left a quoted "none" in place. A test that runs the code catches this; a test that greps it cannot.

Every enumeration needs a lower bound

TestEveryHandlerRendersHTML looked for sendEmail, found 15 handlers, and the bound of 18 caught that three more send through sendEmailNoArchive and were being skipped entirely. checked >= 3 in two shell tests exists for the same reason.

Fixtures

Also records why fixtures/cpanel-named.conf is kept exactly as it came off the server: three views and a logging block are the shape that broke, and a tidied copy would stop reproducing the failure.

Every claim in the file was checked against the code before committing — the if named-checkconf guard, both checked >= 3 bounds, minHandlers = 18, the three view blocks in the fixture, and the awk insert.

[0kaba0]

Ready to merge. Three rules, each anchored to a case from this cycle where a green test missed broken code, and the fixture note says why cpanel-named.conf must stay as taken from the server; no upstream names, no attribution, CI green.