Skip to content

Call PolygonMode only if we are NOT in GL ES mode #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebsjames merged 1 commit into from
Jun 3, 2026
Merged

Call PolygonMode only if we are NOT in GL ES mode #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions mplot/VisualModel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,11 +300,14 @@ namespace mplot

if (!this->indices.empty()) {

// Enable/disable wireframe mode per-model on each render call
if (this->flags.test (vm_bools::wireframe)) {
_glfn->PolygonMode (GL_FRONT_AND_BACK, GL_LINE);
} else {
_glfn->PolygonMode (GL_FRONT_AND_BACK, GL_FILL);
// glPolygonMode is OpenGL only and not support on GL ES
if constexpr (mplot::gl::version::gles (glver) == false) {
// Enable/disable wireframe mode per-model on each render call
if (this->flags.test (vm_bools::wireframe)) {
_glfn->PolygonMode (GL_FRONT_AND_BACK, GL_LINE);
} else {
_glfn->PolygonMode (GL_FRONT_AND_BACK, GL_FILL);
}
}

// It is only necessary to bind the vertex array object before rendering
Expand Down Expand Up @@ -360,7 +363,9 @@ namespace mplot
mplot::gl::Util::checkError (__FILE__, __LINE__, _glfn);

// Now render any VisualTextModels
_glfn->PolygonMode (GL_FRONT_AND_BACK, GL_FILL);
if constexpr (mplot::gl::version::gles (glver) == false) {
_glfn->PolygonMode (GL_FRONT_AND_BACK, GL_FILL);
}
auto ti = this->texts.begin();
while (ti != this->texts.end()) { (*ti)->render(); ti++; }

Expand Down
Loading