Skip to content

fix: use crypto.randomBytes for API keys and claim codes (security) #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zk-sable wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use crypto.randomBytes for API keys and claim codes (security) #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions packages/server/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import express, { Request, Response } from 'express';
import cors from 'cors';
import { config } from 'dotenv';
import { randomBytes } from 'node:crypto';

import { memoryStore } from './store.js';
import { createPaymentMiddleware } from './x402.js';
Expand Down Expand Up @@ -102,23 +103,21 @@ const agents: Map<string, Agent> = new Map();
const claimCodes: Map<string, string> = new Map(); // claimCode -> agentId

function generateApiKey(): string {
const chars = 'abcdefghijklmnopqrstuvwxyz0123456789';
return 'crtx_' + Array.from({ length: 32 }, () =>
chars[Math.floor(Math.random() * chars.length)]
).join('');
return 'crtx_' + randomBytes(24).toString('base64url').slice(0, 32);
}

function generateAgentId(): string {
return Math.random().toString(36).substring(2, 10);
return randomBytes(6).toString('base64url').slice(0, 8);
}

function generateClaimCode(): string {
// Format: xxxx-xxxx-xxxx (human-readable)
// Format: xxxx-xxxx-xxxx (human-readable, crypto-secure)
const chars = 'ABCDEFGHJKLMNPQRSTUVWXYZ23456789'; // No confusing chars
const part = () => Array.from({ length: 4 }, () =>
chars[Math.floor(Math.random() * chars.length)]
const bytes = randomBytes(12);
const part = (offset: number) => Array.from({ length: 4 }, (_, i) =>
chars[bytes[offset + i] % chars.length]
).join('');
return `${part()}-${part()}-${part()}`;
return `${part(0)}-${part(4)}-${part(8)}`;
}

const BASE_URL = process.env.BASE_URL || 'https://crtx.tech';
Expand Down